base/mock_time_provider.h - Issue 7232023: Added last_modified field to TemplateURL and database. Updated unit tests, including refactoring ...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/mock_time_provider.h

Issue 7232023: Added last_modified field to TemplateURL and database. Updated unit tests, including refactoring ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Initial upload. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

Property Changes:

Added: svn:eol-style
+ LF

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "testing/gmock/include/gmock/gmock.h"

	6

	7 #include "base/time.h"
	scherkus (not reviewing) 2011/06/22 22:12:51 needs a header guard needs a header guard SteveT 2011/06/23 21:15:55 Oops. Done. Show quoted text On 2011/06/22 22:12:51, scherkus wrote: > needs a header guard Oops. Done.
	8

	9 namespace base {

	10

	11 class MockTimeProvider {
	scherkus (not reviewing) 2011/06/22 22:12:51 class could also use some usage notes I do have t class could also use some usage notes I do have to say this class is so tiny I wonder whether it's worth having in src/base as opposed to just duplicating the code for clock_unittests, etc... brettw 2011/06/22 22:52:41 I don't understand how this works at all. If it's I don't understand how this works at all. If it's in source base, you should assume people don't have a lot of experience with mock. Also, if we do put it in base, it should be in base/test. I'll wait for the documentation to comment about where I think it should go, since I don't really understand how it works now. SteveT 2011/06/23 21:15:55 Added a description and some usage examples. I ag Show quoted text On 2011/06/22 22:12:51, scherkus wrote: > class could also use some usage notes > > I do have to say this class is so tiny I wonder whether it's worth having in > src/base as opposed to just duplicating the code for clock_unittests, etc... Added a description and some usage examples. I agree with you that the class is tiny, but I would rather see it put in the correct, common place rather than fully duplicating it every time we need to mock out Time::Now. SteveT 2011/06/23 21:15:55 I've moved this to base/test and added it to the t Show quoted text On 2011/06/22 22:52:41, brettw wrote: > I don't understand how this works at all. If it's in source base, you should > assume people don't have a lot of experience with mock. Also, if we do put it in > base, it should be in base/test. > > I'll wait for the documentation to comment about where I think it should go, > since I don't really understand how it works now. I've moved this to base/test and added it to the test_support_base target... for now. Andrew and I were expecting opposition to factoring this out of media and into base, so please let us know where you think it belongs. I would rather avoid duplicating code, but since this class is small, we could just keep it in the 2 locations where it's being used if you're really opposed to adding more to base/. I've added a description with a usage example to the file.
	12 public:

	13 MockTimeProvider();

	14 ~MockTimeProvider();

	15

	16 MOCK_METHOD0(Now, Time());

	17

	18 static Time StaticNow();

	19

	20 private:

	21 static MockTimeProvider* instance_;

	22 DISALLOW_COPY_AND_ASSIGN(MockTimeProvider);

	23 };

	24

	25 } // namespace

OLD	NEW

« no previous file with comments | « no previous file | base/mock_time_provider.cc » ('j') | chrome/browser/search_engines/template_url_service.h » ('J')