Cleanup GrContextFactory and make it's subclasses private

Cleanup GrContextFactory and make it's subclasses private

Committed: https://skia.googlesource.com/skia/+/e4545210c950f98d9fa20f51bc1be6c5591534bd

[djsollen, 2014-11-13 17:45:42]

djsollen@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[bsalomon, 2014-11-13 17:49:32]

https://codereview.chromium.org/723183002/diff/1/gyp/gpu.gypi
File gyp/gpu.gypi (right):

https://codereview.chromium.org/723183002/diff/1/gyp/gpu.gypi#newcode76
gyp/gpu.gypi:76: '<(skia_src_path)/gpu/GrContextFactory.cpp',
Kind of a bummer to bake this into the main library. Would it work to put this
in gputest.gyp?

[djsollen, 2014-11-13 18:32:15]

https://codereview.chromium.org/723183002/diff/1/gyp/gpu.gypi
File gyp/gpu.gypi (right):

https://codereview.chromium.org/723183002/diff/1/gyp/gpu.gypi#newcode76
gyp/gpu.gypi:76: '<(skia_src_path)/gpu/GrContextFactory.cpp',
On 2014/11/13 17:49:32, bsalomon wrote:
> Kind of a bummer to bake this into the main library. Would it work to put this
> in gputest.gyp?

Done.

[bsalomon, 2014-11-13 18:50:51]

lgtm

[djsollen, 2014-11-13 18:53:16]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2014-11-13 18:54:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/723183002/20001

[commit-bot: I haz the power, 2014-11-13 19:13:02]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e4545210c950f98d9fa20f51bc1be6c5591534bd

[humper, 2014-11-17 19:01:54]

On 2014/11/13 19:13:02, I haz the power (commit-bot) wrote:
> Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/e4545210c950f98d9fa20f51bc1be6c5591534bd

This change has broken skfiddle; I can no longer include GrContextFactory.h.

What's the New Way?

[bsalomon, 2014-11-17 19:27:24]

On 2014/11/17 19:01:54, humper wrote:
> On 2014/11/13 19:13:02, I haz the power (commit-bot) wrote:
> > Committed patchset #2 (id:20001) as
> >
https://skia.googlesource.com/skia/+/e4545210c950f98d9fa20f51bc1be6c5591534bd
> 
> This change has broken skfiddle; I can no longer include GrContextFactory.h.
> 
> What's the New Way?

I think you either have to create a GrContext without the factory, or put
src/gpu in your include path. GrContextFactory isn't really intended for Skia
clients, but for our test tools. Arguably, the skfiddle.com backend fits into
the latter category and can include private headers.