Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 72293002: Test that UTF-16LE and UCS-4LE work properly. (Closed)

Created:
7 years, 1 month ago by JF
Modified:
7 years, 1 month ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Test that UTF-16LE and UCS-4LE work properly. Those were added to added to newlib in https://codereview.chromium.org/70163008/, and regular UTF-16/UCS-4 were kept as-is since they don't increase pexe size even when used. R=dschuff@chromium.org TEST= ./scons run_iconv_test -j32 bitcode=1 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12403

Patch Set 1 #

Patch Set 2 : Mark iconv tests broken on all but bitcode targets. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+988 lines, -3 lines) Patch
M tests/libc/iconv.c View 5 chunks +985 lines, -1 line 0 comments Download
M tests/libc/nacl.scons View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
JF
7 years, 1 month ago (2013-11-14 03:31:09 UTC) #1
JF
I'll of course need to roll the newlib version in this CL, but 70163008 needs ...
7 years, 1 month ago (2013-11-14 03:32:24 UTC) #2
Derek Schuff
lgtm
7 years, 1 month ago (2013-11-14 17:13:33 UTC) #3
JF
Waiting on newlib roll: https://codereview.chromium.org/75453002
7 years, 1 month ago (2013-11-18 17:23:58 UTC) #4
JF
On 2013/11/18 17:23:58, JF wrote: > Waiting on newlib roll: > https://codereview.chromium.org/75453002 Waiting on this ...
7 years, 1 month ago (2013-11-18 19:31:17 UTC) #5
JF
> Waiting on this instead: > https://codereview.chromium.org/75563002 > > I'll also need to mark the ...
7 years, 1 month ago (2013-11-18 20:45:00 UTC) #6
JF
Valgrind failures are the usual ones, I'll commit once the tree opens.
7 years, 1 month ago (2013-11-18 22:08:54 UTC) #7
JF
7 years, 1 month ago (2013-11-18 22:36:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r12403 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698