Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 75563002: Update TOOL_REVISIONS for PNaCl 12372->12398 (Closed)

Created:
7 years, 1 month ago by JF
Modified:
7 years, 1 month ago
Reviewers:
Derek Schuff, JF
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Update TOOL_REVISIONS for PNaCl 12372->12398 Command-line specified PNaCl change: git svn id: 12398 hash: 3fb8e1cf83379d2c52b01f768fb87cef289d1dcc author: jfb@chromium.org date: 2013-11-18 16:43:05 +0000 subject: Build libc++ biased bitcode. bug: https://code.google.com/p/nativeclient/issues/detail?id=3623 test: ./pnacl/scripts/llvm-test.py --libcxx-tests review url: https://codereview.chromium.org/73693005 reviewers: dschuff@chromium.org body: ============================================================================ This allows us to eventually make libc++ the default C++ library: the IRT requires the biased build. ============================================================================ TOOL_REVISIONS update points at PNaCl version: git svn id: 12372 hash: f515a52b280938f902bbbafd7861c8d260d798fd date: 2013-11-09 05:32:42 +0000 subject: PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS commits since: 28 Most recent TOOL_REVISIONS update: hash: ba3111a6ea685c5501ccebf6e36b861f17ce3bfa author: nfullagar@google.com date: 2013-11-13 19:12:51 +0000 subject: Revert 12382 "Deploy new x86 binutils" commits since: 15 R=dschuff@chromium.org, jfb@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M TOOL_REVISIONS View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
JF
7 years, 1 month ago (2013-11-18 19:30:05 UTC) #1
Derek Schuff
lgtm
7 years, 1 month ago (2013-11-18 20:30:42 UTC) #2
JF
Valgrind failures look like the usual.
7 years, 1 month ago (2013-11-18 20:35:56 UTC) #3
JF
7 years, 1 month ago (2013-11-18 20:36:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r12401 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698