Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests/libc/nacl.scons

Issue 72293002: Test that UTF-16LE and UCS-4LE work properly. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Rebase. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/libc/iconv.c ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/libc/nacl.scons
diff --git a/tests/libc/nacl.scons b/tests/libc/nacl.scons
index 04c37dffa125e37c03ed158eadd2cf174403fc23..87eebae023250c11cb386f7a0a89719bc844d102 100644
--- a/tests/libc/nacl.scons
+++ b/tests/libc/nacl.scons
@@ -45,8 +45,9 @@ AddLibcTest(env, 'strtoll.c', '0')
AddLibcTest(env, 'strtoull.c', '0')
AddLibcTest(env, 'wcstoll.c', '0', is_broken=env.Bit('nacl_glibc'))
AddLibcTest(env, 'iconv.c', '0',
- is_broken=(env.Bit('nacl_glibc') or
- (env.Bit('target_arm') and not env.Bit('bitcode'))))
+# TODO(jfb) Various breakage on newlib ARM and x86 toolchains as well
+# as on glibc.
+ is_broken=not env.Bit('bitcode'))
# Test that using link-time optimization does not convert calls to
# library functions that were never linked in.
« no previous file with comments | « tests/libc/iconv.c ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698