Use uint16 for port numbers, misc edition

sync/internal_api/attachments/attachment_uploader_impl_unittest.cc

Index: sync/internal_api/attachments/attachment_uploader_impl_unittest.cc
diff --git a/sync/internal_api/attachments/attachment_uploader_impl_unittest.cc b/sync/internal_api/attachments/attachment_uploader_impl_unittest.cc
index 1213b9faaa47df0a15b868217c6c1d2134f3f286..31275bbcfbb958abe149d372a35ac551dd102848 100644
--- a/sync/internal_api/attachments/attachment_uploader_impl_unittest.cc
+++ b/sync/internal_api/attachments/attachment_uploader_impl_unittest.cc
@@ -275,7 +275,7 @@ void AttachmentUploaderImplTest::SetUp() {
       base::Bind(&RequestHandler::HandleRequest,
                  base::Unretained(request_handler_.get())));
 
-  GURL url(base::StringPrintf("http://localhost:%d/", server_.port()));
+  GURL url(base::StringPrintf("http://localhost:%u/", server_.port()));

[Peter Kasting, 2014/11/12 23:53:55]

I don't think the distinction here actually matters, given that a uint16 is
smaller than an int, but this feels more technically correct.

[cpu_(ooo_6.6-7.5), 2014/11/14 18:37:06]

I imagine printf'ing is not the best practice here. There must be some url
builder helper somewhere I hope.

[Peter Kasting, 2014/11/14 20:36:45]

I think we could construct "http://localhost/" and then do a replacement to
insert the port, but honestly I'm not bugged by this route -- it's short, clear,
and guaranteed to work correctly.

 
   token_service_.reset(new MockOAuth2TokenService);
   scoped_refptr<OAuth2TokenServiceRequest::TokenServiceProvider>