Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: remoting/protocol/chromium_socket_factory.cc

Issue 722503002: Use uint16 for port numbers, misc edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/chromium_socket_factory.cc
diff --git a/remoting/protocol/chromium_socket_factory.cc b/remoting/protocol/chromium_socket_factory.cc
index 0cfa1ad706e3b6f7ca68da5229d5a3007589d966..6777937d93d7b103d9b6f14a7b72edd2bec77157 100644
--- a/remoting/protocol/chromium_socket_factory.cc
+++ b/remoting/protocol/chromium_socket_factory.cc
@@ -122,10 +122,10 @@ bool UdpPacketSocket::Init(const rtc::SocketAddress& local_address,
return false;
}
- for (uint16 port = min_port; port <= max_port; ++port) {
+ for (uint32 port = min_port; port <= max_port; ++port) {
Peter Kasting 2014/11/12 23:53:55 The old code was unsafe if a caller passed 65535 f
socket_.reset(new net::UDPServerSocket(NULL, net::NetLog::Source()));
int result = socket_->Listen(
- net::IPEndPoint(local_endpoint.address(), port));
+ net::IPEndPoint(local_endpoint.address(), static_cast<uint16>(port)));
if (result == net::OK) {
break;
} else {

Powered by Google App Engine
This is Rietveld 408576698