Use uint16 for port numbers, misc edition

sync/internal_api/attachments/attachment_uploader_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/internal_api/public/attachments/attachment_uploader_impl.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/ref_counted_memory.h"
@@ skipping 257 matching lines @@
   request_handler_.reset(new RequestHandler(message_loop_.message_loop_proxy(),
                                             weak_ptr_factory_.GetWeakPtr()));
   url_request_context_getter_ =
       new net::TestURLRequestContextGetter(message_loop_.message_loop_proxy());
 
   ASSERT_TRUE(server_.InitializeAndWaitUntilReady());
   server_.RegisterRequestHandler(
       base::Bind(&RequestHandler::HandleRequest,
                  base::Unretained(request_handler_.get())));
 
-  GURL url(base::StringPrintf("http://localhost:%d/", server_.port()));
+  GURL url(base::StringPrintf("http://localhost:%u/", server_.port()));

[Peter Kasting, 2014/11/12 23:53:55]

I don't think the distinction here actually matters, given that a uint16 is
smaller than an int, but this feels more technically correct.

[cpu_(ooo_6.6-7.5), 2014/11/14 18:37:06]

I imagine printf'ing is not the best practice here. There must be some url
builder helper somewhere I hope.

[Peter Kasting, 2014/11/14 20:36:45]

I think we could construct "http://localhost/" and then do a replacement to
insert the port, but honestly I'm not bugged by this route -- it's short, clear,
and guaranteed to work correctly.

 
   token_service_.reset(new MockOAuth2TokenService);
   scoped_refptr<OAuth2TokenServiceRequest::TokenServiceProvider>
       token_service_provider(new TokenServiceProvider(token_service_.get()));
 
   OAuth2TokenService::ScopeSet scopes;
   scopes.insert(GaiaConstants::kChromeSyncOAuth2Scope);
   uploader().reset(new AttachmentUploaderImpl(url,
                                               url_request_context_getter_,
                                               kAccountId,
@@ skipping 349 matching lines @@
   hello_world->data() = "hello world";
   EXPECT_EQ("yZRlqg==",
             AttachmentUploaderImpl::ComputeCrc32cHash(
                 hello_world->front_as<char>(), hello_world->size()));
 }
 
 // TODO(maniscalco): Add test case for when we are uploading an attachment that
 // already exists.  409 Conflict? (bug 379825)
 
 }  // namespace syncer