Use uint16 for port numbers, misc edition

remoting/protocol/chromium_socket_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/chromium_socket_factory.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "jingle/glue/utils.h"
@@ skipping 104 matching lines @@
 }
 
 bool UdpPacketSocket::Init(const rtc::SocketAddress& local_address,
                            uint16 min_port, uint16 max_port) {
   net::IPEndPoint local_endpoint;
   if (!jingle_glue::SocketAddressToIPEndPoint(
           local_address, &local_endpoint)) {
     return false;
   }
 
-  for (uint16 port = min_port; port <= max_port; ++port) {
+  for (uint32 port = min_port; port <= max_port; ++port) {

[Peter Kasting, 2014/11/12 23:53:55]

The old code was unsafe if a caller passed 65535 for |max_port|.

     socket_.reset(new net::UDPServerSocket(NULL, net::NetLog::Source()));
     int result = socket_->Listen(
-        net::IPEndPoint(local_endpoint.address(), port));
+        net::IPEndPoint(local_endpoint.address(), static_cast<uint16>(port)));
     if (result == net::OK) {
       break;
     } else {
       socket_.reset();
     }
   }
 
   if (!socket_.get()) {
     // Failed to bind the socket.
     return false;
@@ skipping 251 matching lines @@
   return NULL;
 }
 
 rtc::AsyncResolverInterface*
 ChromiumPacketSocketFactory::CreateAsyncResolver() {
   return new rtc::AsyncResolver();
 }
 
 }  // namespace protocol
 }  // namespace remoting