ninja/win: Let link-wrapper convert /s to \s in the linker command.

ninja/win: Let link-wrapper convert /s to \s in the linker command.

ExecLinkWrapper() runs a subprocess with shell=True, so that "link.exe" is
looked up using PATH from the environment loaded from environment.x86 in the
build directory.

shell=True implies that forward slashes in the path to the linker (say, if a
custom linker, such as lld-link.exe is used) don't work. If the linker command
is '..\../lld-link.exe', the command with fail with
"'..\..' is not recognized as an internal or external command".

So manually replace forward slashes with backslashes in the link command before
attempting to run it.

BUG=chromium:436277
r2008

[Nico, 2014-11-25 01:12:09]

thakis@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2014-11-25 01:16:07]

lgtm

https://codereview.chromium.org/722073004/diff/1/pylib/gyp/win_tool.py
File pylib/gyp/win_tool.py (right):

https://codereview.chromium.org/722073004/diff/1/pylib/gyp/win_tool.py#newcod...
pylib/gyp/win_tool.py:119: link = subprocess.Popen((args[0].replace('/', '\\'),)
+ args[1:],
nit; i'd probably make it a list to avoid the trailing , since it's going to
have to turn into a list anyway, but don't change if you like this better

[Nico, 2014-11-25 01:19:01]

https://codereview.chromium.org/722073004/diff/1/pylib/gyp/win_tool.py
File pylib/gyp/win_tool.py (right):

https://codereview.chromium.org/722073004/diff/1/pylib/gyp/win_tool.py#newcod...
pylib/gyp/win_tool.py:119: link = subprocess.Popen((args[0].replace('/', '\\'),)
+ args[1:],
On 2014/11/25 01:16:07, scottmg wrote:
> nit; i'd probably make it a list to avoid the trailing , since it's going to
> have to turn into a list anyway, but don't change if you like this better

You mean

  [args[0].replace...0] + list(args[1:])

? (without the list conversion on the rhs, python will complain about
concatenating lists and tuples)

Done.

[scottmg, 2014-11-25 01:23:44]

On 2014/11/25 01:19:01, Nico wrote:
> https://codereview.chromium.org/722073004/diff/1/pylib/gyp/win_tool.py
> File pylib/gyp/win_tool.py (right):
> 
>
https://codereview.chromium.org/722073004/diff/1/pylib/gyp/win_tool.py#newcod...
> pylib/gyp/win_tool.py:119: link = subprocess.Popen((args[0].replace('/',
'\\'),)
> + args[1:],
> On 2014/11/25 01:16:07, scottmg wrote:
> > nit; i'd probably make it a list to avoid the trailing , since it's going to
> > have to turn into a list anyway, but don't change if you like this better
> 
> You mean
> 
>   [args[0].replace...0] + list(args[1:])
> 
> ? (without the list conversion on the rhs, python will complain about
> concatenating lists and tuples)
> 
> Done.

Oh, sorry! I was thinking *args was a list for some reason. :/ ps#1 is probably
better then, but either lgtm.