ninja/win: Let link-wrapper convert /s to \s in the linker command.

pylib/gyp/win_tool.py

 #!/usr/bin/env python
 
 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility functions for Windows builds.
 
 These functions are executed via gyp-win-tool when using the ninja generator.
 """
@@ skipping 98 matching lines @@
       shutil.copy2(source, dest)
 
   def ExecLinkWrapper(self, arch, use_separate_mspdbsrv, *args):
     """Filter diagnostic output from link that looks like:
     '   Creating library ui.dll.lib and object ui.dll.exp'
     This happens when there are exports from the dll or exe.
     """
     env = self._GetEnv(arch)
     if use_separate_mspdbsrv == 'True':
       self._UseSeparateMspdbsrv(env, args)
-    link = subprocess.Popen(args,
+    link = subprocess.Popen((args[0].replace('/', '\\'),) + args[1:],

[scottmg, 2014/11/25 01:16:07]

nit; i'd probably make it a list to avoid the trailing , since it's going to
have to turn into a list anyway, but don't change if you like this better

[Nico, 2014/11/25 01:19:01]

You mean

  [args[0].replace...0] + list(args[1:])

? (without the list conversion on the rhs, python will complain about
concatenating lists and tuples)

Done.

                             shell=True,
                             env=env,
                             stdout=subprocess.PIPE,
                             stderr=subprocess.STDOUT)
     out, _ = link.communicate()
     for line in out.splitlines():
       if not line.startswith('   Creating library '):
         print line
     return link.returncode
 
@@ skipping 176 matching lines @@
     project_dir = os.path.relpath(project_dir, BASE_DIR)
     selected_files = selected_files.split(';')
     ninja_targets = [os.path.join(project_dir, filename) + '^^'
         for filename in selected_files]
     cmd = ['ninja.exe']
     cmd.extend(ninja_targets)
     return subprocess.call(cmd, shell=True, cwd=BASE_DIR)
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))