Chromium Code Reviews Chromium Code Reviews
Issue
721973002:
Navigation transitions (web to native app): Get names and rects of transition elements (Step 4) (Closed)
DescriptionNavigation transitions (web to native app): Get names and rects of transition elements (Step 4)
Web to native app navigation transition uses Activity Transitions APIs in Android L. It requires the names and rects of transition elements. This CL gets the names and rects and pass them to TransitionRequestManager.
Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit#
Demo video: https://drive.google.com/a/google.com/file/d/0B3hetueIc91Gd01DU25uT2hWU2M/view?usp=sharing
Activity Transitions in Android L: https://developer.android.com/preview/material/animations.html#transitions
================
Originally this was a 3-way patch since it involves API change in WebFrameClient.h. After the chrome side impl was committed (step 1), we found that it is better to pass struct instead of long list of params. So this turns out to be a 5-way patch.
Here are the 5 steps:
1. Chrome side - save the data (https://codereview.chromium.org/652283002/).
2. Blink side - getting the data and introduce struct WebTransitionElementData, but still using long list of params (https://codereview.chromium.org/654953002/).
3. Chrome side - implement the API with WebTransitionElementData (https://codereview.chromium.org/679813003/).
4. Blink side - remove old APIs that use long list of params and start to use new API with WebTransitionElementData (this CL).
5. Chrome side - remove redundent implmentations of the old APIs (https://codereview.chromium.org/728653003/).
BUG=370696
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185334
Patch Set 1 #
Total comments: 2
Patch Set 2 : review fix #
Messages
Total messages: 8 (2 generated)
|
|||||||||||||||||||||||||||||||||||||
