Navigation transitions (web to native app): Get names and rects of transition elements (Step 4)

public/web/WebTransitionElementData.h

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebTransitionElementData_h
 #define WebTransitionElementData_h
 
+#if INSIDE_BLINK
+#include "core/dom/Document.h"

[Nate Chapin, 2014/11/13 19:27:30]

Including core/ from public/web/ is a layering violation. The
WebTransitionElement constructor should probably just take a WebString and a
WebRect.

[Zhen Wang, 2014/11/13 21:56:03]

I see. Assigning the values in FrameLoaderClientImpl.cpp now.

+#endif
 #include "../platform/WebRect.h"
 #include "../platform/WebString.h"
 #include "../platform/WebVector.h"
 
 namespace blink {
 
 struct WebTransitionElement {
     WebString id;
     WebRect rect;
+
+    WebTransitionElement()
+        : id(WebString())
+        , rect(WebRect()) { }
+
+#if INSIDE_BLINK
+    WebTransitionElement(const Document::TransitionElement& element)
+        : id(element.id)
+        , rect(element.rect) { }
+#endif
 };
 
 struct WebTransitionElementData {
     WebString scope;
     WebString selector;
     WebString markup;
     WebVector<WebTransitionElement> elements;
 
     WebTransitionElementData(const WebString& scope, const WebString& selector, const WebString& markup, const WebVector<WebTransitionElement>& elements)
         : scope(scope)
         , selector(selector)
         , markup(markup)
         , elements(elements) { }
 };
 
 } // namespace blink
 
 #endif