public/web/WebFrameClient.h - Issue 721973002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 4)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebFrameClient.h

Issue 721973002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 4) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review fix Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebFrameClient.h

diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h

index 0000f0f92654fa5e7d64ba5bc779b06afec9f808..a932e075e6c6c21ec5c852b440f9ef3ebaffd8ea 100644

--- a/public/web/WebFrameClient.h

+++ b/public/web/WebFrameClient.h

@@ -319,11 +319,6 @@ public:

// Provides serialized markup of transition elements for use in the following navigation.

virtual void addNavigationTransitionData(const WebTransitionElementData&) { }

- // FIXME: remove the following two addNavigationTransitionData() functions after the chrome side is done.

- virtual void addNavigationTransitionData(const WebString& allowedDestinationOrigin, const WebString& selector, const WebString& markup) { }

- virtual void addNavigationTransitionData(const WebString& allowedDestinationOrigin, const WebString& selector, const WebString& markup, const WebVector<WebString>& ids, const WebVector<WebRect>& rects) { }

// Web Notifications ---------------------------------------------------

// Requests permission to display platform notifications on the origin of this frame.

« no previous file with comments | « Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »