Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 721443006: Revert of [Telemetry] Add browser option that allows disabling crash service (Closed)

Created:
6 years, 1 month ago by nednguyen
Modified:
6 years, 1 month ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Add browser option that allows disabling crash service (patchset #1 id:1 of https://codereview.chromium.org/702173002/) Reason for revert: Bug 424024 is marked fixed. Crash service was not the reason of the flakiness. Original issue's description: > [Telemetry] Add browser option that allows disabling crash service > > TBR=dtu@chromium.org > > BUG=430246 > > Committed: https://crrev.com/797b1a69e4a74be52c6a3841547072321b297a7f > Cr-Commit-Position: refs/heads/master@{#302903} TBR=chrishenry@google.com,kbr@chromium.org,tonyg@chromium.org,dtu@chromium.org NOTREECHECKS=true NOTRY=true BUG=430246 Committed: https://crrev.com/1274bc5d8d608b330eafe86d06a58873bb358492 Cr-Commit-Position: refs/heads/master@{#304453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 1 chunk +1 line, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_options.py View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
nednguyen
Created Revert of [Telemetry] Add browser option that allows disabling crash service
6 years, 1 month ago (2014-11-17 19:46:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721443006/1
6 years, 1 month ago (2014-11-17 19:46:56 UTC) #2
Ken Russell (switch to Gerrit)
This flag has to be removed from the GPU bots first.
6 years, 1 month ago (2014-11-17 19:47:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-17 19:48:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-17 19:48:04 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1274bc5d8d608b330eafe86d06a58873bb358492 Cr-Commit-Position: refs/heads/master@{#304453}
6 years, 1 month ago (2014-11-17 19:48:28 UTC) #7
nednguyen
6 years, 1 month ago (2014-11-17 19:55:35 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/738473002/ by nednguyen@google.com.

The reason for reverting is: The flag --disable-crash-service has to be removed
from the gpu recipe first.

Powered by Google App Engine
This is Rietveld 408576698