tools/telemetry/telemetry/core/browser_options.py - Issue 721443006: Revert of [Telemetry] Add browser option that allows disabling crash service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/browser_options.py

Issue 721443006: Revert of [Telemetry] Add browser option that allows disabling crash service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/browser_options.py

diff --git a/tools/telemetry/telemetry/core/browser_options.py b/tools/telemetry/telemetry/core/browser_options.py

index 204f84b375ed506c836573176d722754111b2f62..c097ea7b78a6f84411c5259dcdb9226d0c5bb37b 100644

--- a/tools/telemetry/telemetry/core/browser_options.py

+++ b/tools/telemetry/telemetry/core/browser_options.py

@@ -115,13 +115,6 @@

group.add_option('--print-bootstrap-deps',

action='store_true',

help='Output bootstrap deps list.')

- group.add_option('--disable-crash-service',

- dest='disable_crash_service',

- default=False,

- action='store_true',

- help='Whether to disable crash service. NOTE: this flag '

- 'is added temporarily for crbug.com/424024, and will be '

- 'deprecated as soon as the bug is marked fixed.')

parser.add_option_group(group)

# Platform options

@@ -283,7 +276,6 @@

def UpdateFromParseResults(self, finder_options):

"""Copies our options from finder_options"""

browser_options_list = [

- 'disable_crash_service',

'extra_browser_args_as_string',

'extra_wpr_args_as_string',

'netsim',

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py ('k') | no next file » | no next file with comments »