tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py - Issue 721443006: Revert of [Telemetry] Add browser option that allows disabling crash service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

Issue 721443006: Revert of [Telemetry] Add browser option that allows disabling crash service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

index 8433dae0a03188c3baec815d96b9d0e3f71d6552..b7d0c62419787c2ac0be5cf20343a7a541de5572 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

@@ -185,9 +185,7 @@

env['CHROME_HEADLESS'] = '1' # Don't upload minidumps.

env['BREAKPAD_DUMP_LOCATION'] = self._tmp_minidump_dir

env['CHROME_BREAKPAD_PIPE_NAME'] = self._GetCrashServicePipeName()

- # TODO(nednguyen): maybe remove this after crbug.com/424024 is resolved.

- if not self.browser_options.disable_crash_service:

- self._crash_service = self._StartCrashService()

+ self._crash_service = self._StartCrashService()

logging.debug('Starting Chrome %s', args)

if not self.browser_options.show_stdout:

self._tmp_output_file = tempfile.NamedTemporaryFile('w', 0)

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/browser_options.py » ('j') | no next file with comments »