[Telemetry] Move test.DidRunTest call to shared_page_state.TearDown().

[Telemetry] Move test.DidRunTest call to shared_page_state.TearDown().

The main motivation is to remove the usage of browser instance in page_runner
(along with https://codereview.chromium.org/737463002/).

One behavior change to notice is that the original implementation calls
DidRunTest exactly once, but this patch may make DidRunTest called multiple
times.

There are 3 perf tests that overrides page_test.DidRunTest:
dom_perf.DidRunTest: which doesn't touch browser.
peacekeeper.DidRunTest: which doesn't touch browser.
page_cycler.DidRunTest: use browser to get the IO metric.

The reason why page test has DidRunTest hook is that it provides the way to
summarize statistics for a *single browser instance* across many tests. If
TearDown is called the second time, the browser must be restarted hence makes
the DidRunTest's computation meaningless. This scenario does create test
failures, so the dashboard should be adjusted to ignore the summary metrics in
case this failure happens.

BUG=418278
Committed: https://crrev.com/e32e9ce39e8d2f7c077f38591a1ca0175540faa0
Cr-Commit-Position: refs/heads/master@{#304515}

[nednguyen, 2014-11-17 18:35:06]

nednguyen@google.com changed reviewers:
+ chrishenry@google.com, dtu@chromium.org, tonyg@chromium.org

[chrishenry, 2014-11-17 19:41:35]

lgtm

We chatted offline about this and Ned convinced me that there are no other good
solution that we can pursue in the short term. I asked Ned to open a bug about
this.

https://codereview.chromium.org/721443005/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_runner.py (left):

https://codereview.chromium.org/721443005/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_runner.py:225:
test.DidRunTest(state.browser, results)
Maybe we should just pass an app instead of browser for now? Still not quite the
right solution.

https://codereview.chromium.org/721443005/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/shared_page_state.py (right):

https://codereview.chromium.org/721443005/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/shared_page_state.py:197:
self._test.DidRunTest(self.browser, results)
Can you add add a HACK note here? SharedUserStory should not need to know about
calling DidRunTest at all.

[nednguyen, 2014-11-17 22:06:01]

https://codereview.chromium.org/721443005/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_runner.py (left):

https://codereview.chromium.org/721443005/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_runner.py:225:
test.DidRunTest(state.browser, results)
On 2014/11/17 19:41:34, chrishenry wrote:
> Maybe we should just pass an app instead of browser for now? Still not quite
the
> right solution.

Yeah, not the right ultimate solution. But let's leave with it for now.

[nednguyen, 2014-11-17 22:06:06]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-11-17 22:08:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/721443005/20001

[commit-bot: I haz the power, 2014-11-17 23:29:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-17 23:29:48]

Patchset 2 (id:??) landed as
https://crrev.com/e32e9ce39e8d2f7c077f38591a1ca0175540faa0
Cr-Commit-Position: refs/heads/master@{#304515}