tools/telemetry/telemetry/page/shared_page_state.py - Issue 721443005: [Telemetry] Move test.DidRunTest call to shared_page_state.TearDown().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/shared_page_state.py

Issue 721443005: [Telemetry] Move test.DidRunTest call to shared_page_state.TearDown(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Chris's comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/shared_page_state.py

diff --git a/tools/telemetry/telemetry/page/shared_page_state.py b/tools/telemetry/telemetry/page/shared_page_state.py

index 2858ef4f373cc3d40e4c4aa82aebc8f61dfbca34..913914e01c3130e94da1f45eae2a7c7ff41e5c44 100644

--- a/tools/telemetry/telemetry/page/shared_page_state.py

+++ b/tools/telemetry/telemetry/page/shared_page_state.py

@@ -210,7 +210,10 @@ class SharedPageState(object):

self._ImplicitPageNavigation()

self._test.RunPage(self._current_page, self._current_tab, results)

- def TearDown(self):

+ def TearDown(self, results):

+ # NOTE: this is a HACK to get page_runner to be generic enough for any

+ # user_story. Other SharedUserStory should not call DidRunTest this way.

+ self._test.DidRunTest(self.browser, results)

self._StopBrowser()

def _StopBrowser(self):

« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | no next file » | no next file with comments »