Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 721443005: [Telemetry] Move test.DidRunTest call to shared_page_state.TearDown(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Chris's comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/shared_page_state.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index 0d20fd8a91157831cca3a1dd181b9f323f54aed4..972ca12da9f0a7ded9d1322f9f62b2e9db9b0061 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -102,7 +102,7 @@ def _RunPageAndHandleExceptionIfNeeded(test, page_set, expectations,
ProcessError()
except (exceptions.TabCrashException, exceptions.BrowserGoneException):
ProcessError()
- state.TearDown()
+ state.TearDown(results)
if test.is_multi_tab_test:
logging.error('Aborting multi-tab test after browser or tab crashed at '
'page %s' % page.url)
@@ -199,7 +199,7 @@ def Run(test, page_set, expectations, finder_options, results):
# Tear down & restart the state for unhandled exceptions thrown by
# _RunPageAndHandleExceptionIfNeeded.
results.AddValue(failure.FailureValue(page, sys.exc_info()))
- state.TearDown()
+ state.TearDown(results)
state = shared_page_state.SharedPageState(test, finder_options)
finally:
_CheckThermalThrottling(state.platform)
@@ -212,8 +212,7 @@ def Run(test, page_set, expectations, finder_options, results):
logging.error('Too many failures. Aborting.')
test.RequestExit()
finally:
- test.DidRunTest(state.browser, results)
- state.TearDown()
+ state.TearDown(results)
def _ShuffleAndFilterPageSet(page_set, finder_options):
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/shared_page_state.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698