content/browser/renderer_host/p2p/socket_host_udp_unittest.cc - Issue 721273002: Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_host_udp_unittest.cc

Issue 721273002: Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/dial/dial_service.cc ('k') | content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc » ('j') | net/udp/udp_socket_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/p2p/socket_host_udp_unittest.cc

diff --git a/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc b/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc

index 5d67a24fc3327563c21773cc973ae8ba7084e7b0..6b502e739bc336a128c0df5a1f3c85ef683954e4 100644

--- a/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc

+++ b/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc

@@ -117,7 +117,10 @@ class FakeDatagramServerSocket : public net::DatagramServerSocket {

void AllowAddressReuse() override { NOTIMPLEMENTED(); }

- void AllowBroadcast() override { NOTIMPLEMENTED(); }

+ int SetBroadcast(bool broadcast) override {

+ NOTIMPLEMENTED();

+ return net::ERR_NOT_IMPLEMENTED;

+ }

int JoinGroup(const net::IPAddressNumber& group_address) const override {

NOTIMPLEMENTED();