chrome/browser/extensions/api/dial/dial_service.cc - Issue 721273002: Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/dial/dial_service.cc

Issue 721273002: Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/dial/dial_service.cc

diff --git a/chrome/browser/extensions/api/dial/dial_service.cc b/chrome/browser/extensions/api/dial/dial_service.cc

index 4197d62b9f1b3750d35516453a6162e2dda625ec..77a893448df93a5a8304a77e5bcbb6c29d9c4f5c 100644

--- a/chrome/browser/extensions/api/dial/dial_service.cc

+++ b/chrome/browser/extensions/api/dial/dial_service.cc

@@ -173,7 +173,7 @@ bool DialServiceImpl::DialSocket::CreateAndBindSocket(

rand_cb,

net_log,

net_log_source));

- socket_->AllowBroadcast();

+ socket_->SetBroadcast(true);

// 0 means bind a random port

IPEndPoint address(bind_ip_address, 0);

« no previous file with comments | « no previous file | content/browser/renderer_host/p2p/socket_host_udp_unittest.cc » ('j') | net/udp/udp_socket_win.cc » ('J')