Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

Issue 721273002: Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc
diff --git a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc
index 26c0e44ee34f6277a36309c6dd4b5c2c73a0e4c1..3e9983f76c172a63d1238147ba62e57c3acec9a6 100644
--- a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc
+++ b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc
@@ -265,8 +265,13 @@ void PepperUDPSocketMessageFilter::DoBind(
if (allow_address_reuse_)
socket->AllowAddressReuse();
- if (allow_broadcast_)
- socket->AllowBroadcast();
+ if (allow_broadcast_) {
+ int32_t pp_result = NetErrorToPepperError(socket->SetBroadcast(true));
+ if (pp_result != PP_OK) {
+ SendBindError(context, pp_result);
+ return;
+ }
+ }
int32_t pp_result =
NetErrorToPepperError(socket->Listen(net::IPEndPoint(address, port)));

Powered by Google App Engine
This is Rietveld 408576698