Pass PaintBehaviorRenderingClipPathAsMask in PaintInfo

Pass PaintBehaviorRenderingClipPathAsMask in PaintInfo

Passing PaintInfo to SVGPaintServer::updateGraphicsContext (instead of
GraphicsContext), PaintInfo::paintBehavior can be used instead of the
view's.
This also reduces SVGRenderSupport::isRenderingClipPathAsMaskImage to a
single/simple bit-test, which should help some workloads.

BUG=434376
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185544

[fs, 2014-11-18 17:25:51]

fs@opera.com changed reviewers:
+ fmalita@chromium.org

[fs, 2014-11-18 17:26:44]

Originally wrote this while working on the RenderSVGResource stuff, but kept
pushing it forward in hope of improving the logistics... =/

[f(malita), 2014-11-18 17:36:00]

Awesome, this is almost identical to what I had started (so, obviously, lvgtm :)

LGTM w/ some nits.

https://codereview.chromium.org/721073003/diff/1/Source/core/paint/SVGInlineT...
File Source/core/paint/SVGInlineTextBoxPainter.h (right):

https://codereview.chromium.org/721073003/diff/1/Source/core/paint/SVGInlineT...
Source/core/paint/SVGInlineTextBoxPainter.h:32: void paintDecoration(PaintInfo&,
TextDecoration, const SVGTextFragment&);
Let's const-ify PaintInfo& everywhere (the paint param should also be const but
that's a larger cleanup).

https://codereview.chromium.org/721073003/diff/1/Source/core/rendering/svg/SV...
File Source/core/rendering/svg/SVGRenderSupport.cpp (right):

https://codereview.chromium.org/721073003/diff/1/Source/core/rendering/svg/SV...
Source/core/rendering/svg/SVGRenderSupport.cpp:393: GraphicsContext* context =
paintInfo.context;
I would also ASSERT(paintInfo.context == stateSaver.context()) for sanity, but
up to you.

https://codereview.chromium.org/721073003/diff/1/Source/core/rendering/svg/SV...
File Source/core/rendering/svg/SVGRenderSupport.h (right):

https://codereview.chromium.org/721073003/diff/1/Source/core/rendering/svg/SV...
Source/core/rendering/svg/SVGRenderSupport.h:89: static bool
updateGraphicsContext(PaintInfo&, GraphicsContextStateSaver&, RenderStyle*,
RenderObject&, RenderSVGResourceMode, const AffineTransform*
additionalPaintServerTransform = 0);
const PaintInfo&

[fs, 2014-11-18 18:18:34]

https://codereview.chromium.org/721073003/diff/1/Source/core/paint/SVGInlineT...
File Source/core/paint/SVGInlineTextBoxPainter.h (right):

https://codereview.chromium.org/721073003/diff/1/Source/core/paint/SVGInlineT...
Source/core/paint/SVGInlineTextBoxPainter.h:32: void paintDecoration(PaintInfo&,
TextDecoration, const SVGTextFragment&);
On 2014/11/18 17:35:59, Florin Malita wrote:
> Let's const-ify PaintInfo& everywhere (the paint param should also be const
but
> that's a larger cleanup).

Done.

https://codereview.chromium.org/721073003/diff/1/Source/core/rendering/svg/SV...
File Source/core/rendering/svg/SVGRenderSupport.cpp (right):

https://codereview.chromium.org/721073003/diff/1/Source/core/rendering/svg/SV...
Source/core/rendering/svg/SVGRenderSupport.cpp:393: GraphicsContext* context =
paintInfo.context;
On 2014/11/18 17:35:59, Florin Malita wrote:
> I would also ASSERT(paintInfo.context == stateSaver.context()) for sanity, but
> up to you.

Make sense. Done.

https://codereview.chromium.org/721073003/diff/1/Source/core/rendering/svg/SV...
File Source/core/rendering/svg/SVGRenderSupport.h (right):

https://codereview.chromium.org/721073003/diff/1/Source/core/rendering/svg/SV...
Source/core/rendering/svg/SVGRenderSupport.h:89: static bool
updateGraphicsContext(PaintInfo&, GraphicsContextStateSaver&, RenderStyle*,
RenderObject&, RenderSVGResourceMode, const AffineTransform*
additionalPaintServerTransform = 0);
On 2014/11/18 17:36:00, Florin Malita wrote:
> const PaintInfo&

Done.

[fs, 2014-11-18 19:13:31]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-11-18 19:14:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/721073003/20001

[commit-bot: I haz the power, 2014-11-18 19:23:15]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185544