Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 720313002: Push selection gaps logic down to RenderBlockFlow (Closed)

Created:
6 years, 1 month ago by leviw_travelin_and_unemployed
Modified:
6 years, 1 month ago
Reviewers:
dsinclair, chrishtr, pdr.
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Push selection gaps logic down to RenderBlockFlow Part of my ultimate goal of de-coupling invalidation and painting of selection gaps from one function so I can move the painting into BlockFlowPainter. We don't actually paint selection gaps for non-blockFlow RenderBlocks. Make the code actually represent that! Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185396

Patch Set 1 #

Patch Set 2 : Add simplified early out for columns and transforms #

Patch Set 3 : Do we need this code? #

Patch Set 4 : Move it alllll to RenderBlockFlow #

Patch Set 5 : Move it all to RenderBlockFlow AND compile it #

Patch Set 6 : All to RenderBlockFlow && ToT-ed #

Patch Set 7 : Toted again... #

Patch Set 8 : Fix squashing issue #

Patch Set 9 : git cl try #

Patch Set 10 : move even MOAR! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -277 lines) Patch
M Source/core/paint/BlockFlowPainter.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/BlockFlowPainter.cpp View 1 2 3 4 5 6 7 2 chunks +25 lines, -0 lines 0 comments Download
M Source/core/paint/BlockPainter.cpp View 1 2 3 4 5 6 7 2 chunks +1 line, -25 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 2 3 4 5 6 7 8 9 5 chunks +1 line, -16 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 3 4 5 6 7 8 9 4 chunks +0 lines, -232 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 2 3 4 5 6 7 8 9 2 chunks +16 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 2 3 4 5 6 7 8 9 5 chunks +234 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
chrishtr
lgtm
6 years, 1 month ago (2014-11-14 22:52:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720313002/180001
6 years, 1 month ago (2014-11-14 22:55:06 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 23:55:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #10 (id:180001) as 185396

Powered by Google App Engine
This is Rietveld 408576698