Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 719733003: Add Navigation.MainFrameSchemeDifferentPage which excludes same-page navigations. (Closed)

Created:
6 years, 1 month ago by cbentzel
Modified:
6 years, 1 month ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, asvitkine+watch_chromium.org, igrigorik, ajwong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add Navigation.MainFrameSchemeDifferentPage which excludes same-page navigations. Same page navigations include things like location.assign with a fragment identifier change only, or path changes using history.pushState BUG=None Committed: https://crrev.com/794bee2a7d2f731148f0cd5765c550d140ea2000 Cr-Commit-Position: refs/heads/master@{#304498}

Patch Set 1 #

Patch Set 2 : Spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M chrome/browser/tab_contents/navigation_metrics_recorder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/navigation_metrics/navigation_metrics.h View 1 chunk +1 line, -1 line 0 comments Download
M components/navigation_metrics/navigation_metrics.cc View 2 chunks +5 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
cbentzel
I think I'm going to need to change some downstream callers for RecordMainFrameNavigation davidben: Please ...
6 years, 1 month ago (2014-11-12 16:42:48 UTC) #2
davidben
lgtm
6 years, 1 month ago (2014-11-12 18:01:17 UTC) #3
cbentzel
avi: chrome/browser/tab_contents/navigation_metrics_recorder.cc erikwright: components/navigation_metrics/* (perhaps this directory also needs OWNERS?) isherman: histograms.xml
6 years, 1 month ago (2014-11-13 16:55:44 UTC) #6
Avi (use Gerrit)
lgtm navigation_metrics_recorder.cc is cool.
6 years, 1 month ago (2014-11-13 18:59:04 UTC) #7
Ilya Sherman
histograms.xml lgtm
6 years, 1 month ago (2014-11-13 22:40:42 UTC) #8
erikwright (departed)
LGTM but yes an OWNERS file would be a good idea here.
6 years, 1 month ago (2014-11-17 15:56:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719733003/20001
6 years, 1 month ago (2014-11-17 21:18:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-17 22:22:49 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 22:24:36 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/794bee2a7d2f731148f0cd5765c550d140ea2000
Cr-Commit-Position: refs/heads/master@{#304498}

Powered by Google App Engine
This is Rietveld 408576698