chrome/browser/tab_contents/navigation_metrics_recorder.cc - Issue 719733003: Add Navigation.MainFrameSchemeDifferentPage which excludes same-page navigations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/navigation_metrics_recorder.cc

Issue 719733003: Add Navigation.MainFrameSchemeDifferentPage which excludes same-page navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Spacing Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/tab_contents/navigation_metrics_recorder.cc

diff --git a/chrome/browser/tab_contents/navigation_metrics_recorder.cc b/chrome/browser/tab_contents/navigation_metrics_recorder.cc

index b9b034dd7e49b8e779b0e55fc3351a8a82bdffbc..5e9149f3004b920ff60cc5db08504b8b7f33496d 100644

--- a/chrome/browser/tab_contents/navigation_metrics_recorder.cc

+++ b/chrome/browser/tab_contents/navigation_metrics_recorder.cc

@@ -29,7 +29,8 @@ NavigationMetricsRecorder::~NavigationMetricsRecorder() {

void NavigationMetricsRecorder::DidNavigateMainFrame(

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) {

- navigation_metrics::RecordMainFrameNavigation(details.entry->GetVirtualURL());

+ navigation_metrics::RecordMainFrameNavigation(details.entry->GetVirtualURL(),

+ details.is_in_page);

}

void NavigationMetricsRecorder::DidStartLoading(

« no previous file with comments | « no previous file | components/navigation_metrics/navigation_metrics.h » ('j') | no next file with comments »