Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: components/navigation_metrics/navigation_metrics.cc

Issue 719733003: Add Navigation.MainFrameSchemeDifferentPage which excludes same-page navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Spacing Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/navigation_metrics/navigation_metrics.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/navigation_metrics/navigation_metrics.cc
diff --git a/components/navigation_metrics/navigation_metrics.cc b/components/navigation_metrics/navigation_metrics.cc
index acbe25a9b08c1fa79397679f5eadf90acd80eaf3..f7d63e48b7a96f82f62d07450e9cd302664bfd10 100644
--- a/components/navigation_metrics/navigation_metrics.cc
+++ b/components/navigation_metrics/navigation_metrics.cc
@@ -42,7 +42,7 @@ COMPILE_ASSERT(arraysize(kSchemeNames) == SCHEME_MAX + 1,
namespace navigation_metrics {
-void RecordMainFrameNavigation(const GURL& url) {
+void RecordMainFrameNavigation(const GURL& url, bool is_in_page) {
Scheme scheme = SCHEME_UNKNOWN;
for (int i = 1; i < SCHEME_MAX; ++i) {
if (url.SchemeIs(kSchemeNames[i])) {
@@ -52,6 +52,10 @@ void RecordMainFrameNavigation(const GURL& url) {
}
UMA_HISTOGRAM_ENUMERATION(
"Navigation.MainFrameScheme", scheme, SCHEME_MAX);
+ if (!is_in_page) {
+ UMA_HISTOGRAM_ENUMERATION(
+ "Navigation.MainFrameSchemeDifferentPage", scheme, SCHEME_MAX);
+ }
}
} // namespace navigation_metrics
« no previous file with comments | « components/navigation_metrics/navigation_metrics.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698