Remove implicit conversions from scoped_refptr to T* in remoting/

Remove implicit conversions from scoped_refptr to T* in remoting/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG=110610
Committed: https://crrev.com/858fd171915d2a0d0fd5c423d360c72c0eb4f453
Cr-Commit-Position: refs/heads/master@{#303951}

[dcheng, 2014-11-12 23:28:29]

dcheng@chromium.org changed reviewers:
+ wez@chromium.org

[Wez, 2014-11-12 23:57:04]

https://codereview.chromium.org/719353002/diff/1/remoting/base/auto_thread.cc
File remoting/base/auto_thread.cc (right):

https://codereview.chromium.org/719353002/diff/1/remoting/base/auto_thread.cc...
remoting/base/auto_thread.cc:80: AutoThread* thread = new AutoThread(name,
joiner.get());
This should stay as |joiner|.

[dcheng, 2014-11-12 23:59:07]

https://codereview.chromium.org/719353002/diff/1/remoting/base/auto_thread.cc
File remoting/base/auto_thread.cc (right):

https://codereview.chromium.org/719353002/diff/1/remoting/base/auto_thread.cc...
remoting/base/auto_thread.cc:80: AutoThread* thread = new AutoThread(name,
joiner.get());
On 2014/11/12 at 23:57:03, Wez wrote:
> This should stay as |joiner|.

The constructor takes a raw pointer though, so this rewrite is just making
explicit what was already happening.

[Wez, 2014-11-13 00:18:39]

lgtm

https://codereview.chromium.org/719353002/diff/1/remoting/base/auto_thread.cc
File remoting/base/auto_thread.cc (right):

https://codereview.chromium.org/719353002/diff/1/remoting/base/auto_thread.cc...
remoting/base/auto_thread.cc:80: AutoThread* thread = new AutoThread(name,
joiner.get());
On 2014/11/12 23:59:07, dcheng wrote:
> On 2014/11/12 at 23:57:03, Wez wrote:
> > This should stay as |joiner|.
> 
> The constructor takes a raw pointer though, so this rewrite is just making
> explicit what was already happening.

I'd prefer we just switch the ctor to take a refptr, TBH, since that's safer.

[dcheng, 2014-11-13 00:25:24]

https://codereview.chromium.org/719353002/diff/1/remoting/base/auto_thread.cc
File remoting/base/auto_thread.cc (right):

https://codereview.chromium.org/719353002/diff/1/remoting/base/auto_thread.cc...
remoting/base/auto_thread.cc:80: AutoThread* thread = new AutoThread(name,
joiner.get());
On 2014/11/13 00:18:39, Wez wrote:
> On 2014/11/12 23:59:07, dcheng wrote:
> > On 2014/11/12 at 23:57:03, Wez wrote:
> > > This should stay as |joiner|.
> > 
> > The constructor takes a raw pointer though, so this rewrite is just making
> > explicit what was already happening.
> 
> I'd prefer we just switch the ctor to take a refptr, TBH, since that's safer.

Previously, I was converting a lot of these by hand but it took a lot of time. I
have a more general solution in mind that will rewrite constructor arguments
that are used to initialize scoped_refptrs from raw pointers, and apply that
transitively to the constructor's callers... and fix the it Once And For All
(tm).

[dcheng, 2014-11-13 00:26:03]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-11-13 00:28:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/719353002/1

[commit-bot: I haz the power, 2014-11-13 01:17:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-13 01:18:19]

Patchset 1 (id:??) landed as
https://crrev.com/858fd171915d2a0d0fd5c423d360c72c0eb4f453
Cr-Commit-Position: refs/heads/master@{#303951}