Remove implicit conversions from scoped_refptr to T* in remoting/

remoting/base/auto_thread.cc

Index: remoting/base/auto_thread.cc
diff --git a/remoting/base/auto_thread.cc b/remoting/base/auto_thread.cc
index b1d02790e4f655b0bfd8a531c54723b570d83eef..2e5006be3143a291091bde897736bb150686dde7 100644
--- a/remoting/base/auto_thread.cc
+++ b/remoting/base/auto_thread.cc
@@ -77,11 +77,11 @@ scoped_refptr<AutoThreadTaskRunner> AutoThread::CreateWithLoopAndComInitTypes(
     scoped_refptr<AutoThreadTaskRunner> joiner,
     base::MessageLoop::Type loop_type,
     ComInitType com_init_type) {
-  AutoThread* thread = new AutoThread(name, joiner);
+  AutoThread* thread = new AutoThread(name, joiner.get());

[Wez, 2014/11/12 23:57:03]

This should stay as |joiner|.

[dcheng, 2014/11/12 23:59:07]

The constructor takes a raw pointer though, so this rewrite is just making
explicit what was already happening.

[Wez, 2014/11/13 00:18:39]

I'd prefer we just switch the ctor to take a refptr, TBH, since that's safer.

[dcheng, 2014/11/13 00:25:24]

Previously, I was converting a lot of these by hand but it took a lot of time. I
have a more general solution in mind that will rewrite constructor arguments
that are used to initialize scoped_refptrs from raw pointers, and apply that
transitively to the constructor's callers... and fix the it Once And For All
(tm).

   thread->SetComInitType(com_init_type);
   scoped_refptr<AutoThreadTaskRunner> task_runner =
       thread->StartWithType(loop_type);
-  if (!task_runner)
+  if (!task_runner.get())
     delete thread;
   return task_runner;
 }