Remove implicit conversions from scoped_refptr to T* in remoting/

remoting/base/auto_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/base/auto_thread.h"
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
 #include "base/threading/thread_local.h"
@@ skipping 59 matching lines @@
   return CreateWithType(name, joiner, base::MessageLoop::TYPE_DEFAULT);
 }
 
 #if defined(OS_WIN)
 // static
 scoped_refptr<AutoThreadTaskRunner> AutoThread::CreateWithLoopAndComInitTypes(
     const char* name,
     scoped_refptr<AutoThreadTaskRunner> joiner,
     base::MessageLoop::Type loop_type,
     ComInitType com_init_type) {
-  AutoThread* thread = new AutoThread(name, joiner);
+  AutoThread* thread = new AutoThread(name, joiner.get());

[Wez, 2014/11/12 23:57:03]

This should stay as |joiner|.

[dcheng, 2014/11/12 23:59:07]

The constructor takes a raw pointer though, so this rewrite is just making
explicit what was already happening.

[Wez, 2014/11/13 00:18:39]

I'd prefer we just switch the ctor to take a refptr, TBH, since that's safer.

[dcheng, 2014/11/13 00:25:24]

Previously, I was converting a lot of these by hand but it took a lot of time. I
have a more general solution in mind that will rewrite constructor arguments
that are used to initialize scoped_refptrs from raw pointers, and apply that
transitively to the constructor's callers... and fix the it Once And For All
(tm).

   thread->SetComInitType(com_init_type);
   scoped_refptr<AutoThreadTaskRunner> task_runner =
       thread->StartWithType(loop_type);
-  if (!task_runner)
+  if (!task_runner.get())
     delete thread;
   return task_runner;
 }
 #endif
 
 AutoThread::AutoThread(const char* name)
   : startup_data_(NULL),
 #if defined(OS_WIN)
     com_init_type_(COM_INIT_NONE),
 #endif
@@ skipping 110 matching lines @@
       CreateComInitializer(com_init_type_));
 #endif
 
   message_loop.Run();
 
   // Assert that MessageLoop::Quit was called by AutoThread::QuitThread.
   DCHECK(was_quit_properly_);
 }
 
 }  // namespace base