Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 719313003: Revert "pylint: upgrade to 1.3.1" (Closed)

Created:
6 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 1 month ago
Reviewers:
vapier, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Revert "pylint: upgrade to 1.3.1" This reverts commit 451939d582195f20d721bee5ee4d4f4b929c728d. Throws an exception with a missing import, breaking Telemetry's presubmit checks and presumably presubmit checks for all Python files in Chromium. See comment on https://codereview.chromium.org/707353002/ . BUG=chromium:431514 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4432 lines, -18107 lines) Patch
M pylintrc View 2 chunks +4 lines, -4 lines 0 comments Download
A + third_party/logilab/astng/LICENSE.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/logilab/astng/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
A third_party/logilab/astng/__init__.py View 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/logilab/astng/__pkginfo__.py View 1 chunk +44 lines, -0 lines 0 comments Download
A + third_party/logilab/astng/as_string.py View 14 chunks +115 lines, -187 lines 0 comments Download
A + third_party/logilab/astng/bases.py View 17 chunks +83 lines, -71 lines 0 comments Download
A + third_party/logilab/astng/builder.py View 6 chunks +48 lines, -59 lines 0 comments Download
A third_party/logilab/astng/exceptions.py View 1 chunk +60 lines, -0 lines 0 comments Download
A + third_party/logilab/astng/inference.py View 16 chunks +76 lines, -94 lines 0 comments Download
A + third_party/logilab/astng/inspector.py View 12 chunks +70 lines, -54 lines 0 comments Download
A + third_party/logilab/astng/manager.py View 9 chunks +83 lines, -131 lines 0 comments Download
A + third_party/logilab/astng/mixins.py View 6 chunks +26 lines, -12 lines 0 comments Download
A + third_party/logilab/astng/node_classes.py View 34 chunks +99 lines, -146 lines 0 comments Download
A + third_party/logilab/astng/nodes.py View 4 chunks +12 lines, -10 lines 0 comments Download
A + third_party/logilab/astng/protocols.py View 6 chunks +21 lines, -65 lines 0 comments Download
A + third_party/logilab/astng/raw_building.py View 15 chunks +46 lines, -62 lines 0 comments Download
A + third_party/logilab/astng/rebuilder.py View 22 chunks +78 lines, -175 lines 0 comments Download
A + third_party/logilab/astng/scoped_nodes.py View 36 chunks +80 lines, -380 lines 0 comments Download
A + third_party/logilab/astng/utils.py View 7 chunks +32 lines, -29 lines 0 comments Download
D third_party/logilab/astroid/LICENSE.txt View 1 chunk +0 lines, -340 lines 0 comments Download
D third_party/logilab/astroid/README.chromium View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/logilab/astroid/__init__.py View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/logilab/astroid/__pkginfo__.py View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/logilab/astroid/as_string.py View 1 chunk +0 lines, -499 lines 0 comments Download
D third_party/logilab/astroid/bases.py View 1 chunk +0 lines, -617 lines 0 comments Download
D third_party/logilab/astroid/brain/py2gi.py View 1 chunk +0 lines, -159 lines 0 comments Download
D third_party/logilab/astroid/brain/py2mechanize.py View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/logilab/astroid/brain/py2qt4.py View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/logilab/astroid/brain/py2stdlib.py View 1 chunk +0 lines, -331 lines 0 comments Download
D third_party/logilab/astroid/builder.py View 1 chunk +0 lines, -237 lines 0 comments Download
D third_party/logilab/astroid/exceptions.py View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/logilab/astroid/inference.py View 1 chunk +0 lines, -400 lines 0 comments Download
D third_party/logilab/astroid/inspector.py View 1 chunk +0 lines, -273 lines 0 comments Download
D third_party/logilab/astroid/manager.py View 1 chunk +0 lines, -347 lines 0 comments Download
D third_party/logilab/astroid/mixins.py View 1 chunk +0 lines, -122 lines 0 comments Download
D third_party/logilab/astroid/modutils.py View 1 chunk +0 lines, -635 lines 0 comments Download
D third_party/logilab/astroid/node_classes.py View 1 chunk +0 lines, -950 lines 0 comments Download
D third_party/logilab/astroid/nodes.py View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/logilab/astroid/protocols.py View 1 chunk +0 lines, -365 lines 0 comments Download
D third_party/logilab/astroid/raw_building.py View 1 chunk +0 lines, -361 lines 0 comments Download
D third_party/logilab/astroid/rebuilder.py View 1 chunk +0 lines, -961 lines 0 comments Download
D third_party/logilab/astroid/scoped_nodes.py View 1 chunk +0 lines, -1277 lines 0 comments Download
D third_party/logilab/astroid/utils.py View 1 chunk +0 lines, -238 lines 0 comments Download
M third_party/logilab/common/LICENSE.txt View 9 chunks +14 lines, -13 lines 0 comments Download
M third_party/logilab/common/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/logilab/common/__init__.py View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/logilab/common/__pkginfo__.py View 3 chunks +4 lines, -14 lines 0 comments Download
M third_party/logilab/common/changelog.py View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/logilab/common/clcommands.py View 6 chunks +29 lines, -31 lines 0 comments Download
M third_party/logilab/common/cli.py View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/logilab/common/compat.py View 5 chunks +171 lines, -6 lines 0 comments Download
M third_party/logilab/common/configuration.py View 35 chunks +85 lines, -122 lines 0 comments Download
M third_party/logilab/common/corbautils.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/logilab/common/daemon.py View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/logilab/common/date.py View 5 chunks +26 lines, -34 lines 0 comments Download
M third_party/logilab/common/dbf.py View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/logilab/common/debugger.py View 3 chunks +3 lines, -7 lines 0 comments Download
M third_party/logilab/common/decorators.py View 6 chunks +17 lines, -15 lines 0 comments Download
M third_party/logilab/common/deprecation.py View 2 chunks +73 lines, -149 lines 0 comments Download
M third_party/logilab/common/fileutils.py View 4 chunks +4 lines, -6 lines 0 comments Download
M third_party/logilab/common/graph.py View 6 chunks +16 lines, -25 lines 0 comments Download
A third_party/logilab/common/hg.py View 1 chunk +130 lines, -0 lines 0 comments Download
M third_party/logilab/common/logging_ext.py View 3 chunks +4 lines, -21 lines 0 comments Download
M third_party/logilab/common/modutils.py View 15 chunks +23 lines, -72 lines 0 comments Download
M third_party/logilab/common/optik_ext.py View 6 chunks +14 lines, -9 lines 0 comments Download
A third_party/logilab/common/pdf_ext.py View 1 chunk +111 lines, -0 lines 0 comments Download
M third_party/logilab/common/pyro_ext.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/logilab/common/pytest.py View 24 chunks +64 lines, -41 lines 0 comments Download
D third_party/logilab/common/registry.py View 1 chunk +0 lines, -1119 lines 0 comments Download
M third_party/logilab/common/shellutils.py View 11 chunks +19 lines, -38 lines 0 comments Download
M third_party/logilab/common/table.py View 7 chunks +6 lines, -12 lines 0 comments Download
M third_party/logilab/common/tasksqueue.py View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/logilab/common/testlib.py View 33 chunks +103 lines, -113 lines 0 comments Download
M third_party/logilab/common/textutils.py View 3 chunks +6 lines, -11 lines 0 comments Download
M third_party/logilab/common/umessage.py View 5 chunks +37 lines, -64 lines 0 comments Download
M third_party/logilab/common/ureports/__init__.py View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/logilab/common/ureports/docbook_writer.py View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/logilab/common/ureports/html_writer.py View 2 chunks +34 lines, -36 lines 0 comments Download
M third_party/logilab/common/ureports/nodes.py View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/logilab/common/ureports/text_writer.py View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/logilab/common/urllib2ext.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/logilab/common/visitor.py View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/pylint.py View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/pylint/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/pylint/__init__.py View 2 chunks +4 lines, -32 lines 0 comments Download
D third_party/pylint/__main__.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/pylint/__pkginfo__.py View 3 chunks +18 lines, -24 lines 0 comments Download
M third_party/pylint/checkers/__init__.py View 8 chunks +47 lines, -27 lines 0 comments Download
M third_party/pylint/checkers/base.py View 22 chunks +293 lines, -676 lines 0 comments Download
M third_party/pylint/checkers/classes.py View 21 chunks +152 lines, -432 lines 0 comments Download
M third_party/pylint/checkers/design_analysis.py View 11 chunks +80 lines, -103 lines 0 comments Download
M third_party/pylint/checkers/exceptions.py View 5 chunks +52 lines, -161 lines 0 comments Download
M third_party/pylint/checkers/format.py View 9 chunks +165 lines, -748 lines 0 comments Download
M third_party/pylint/checkers/imports.py View 14 chunks +77 lines, -97 lines 0 comments Download
M third_party/pylint/checkers/logging.py View 4 chunks +66 lines, -114 lines 0 comments Download
M third_party/pylint/checkers/misc.py View 3 chunks +31 lines, -58 lines 0 comments Download
M third_party/pylint/checkers/newstyle.py View 3 chunks +30 lines, -73 lines 0 comments Download
M third_party/pylint/checkers/raw_metrics.py View 4 chunks +14 lines, -18 lines 0 comments Download
M third_party/pylint/checkers/similar.py View 15 chunks +34 lines, -65 lines 0 comments Download
D third_party/pylint/checkers/stdlib.py View 1 chunk +0 lines, -70 lines 0 comments Download
A third_party/pylint/checkers/string_format.py View 1 chunk +157 lines, -0 lines 0 comments Download
D third_party/pylint/checkers/strings.py View 1 chunk +0 lines, -619 lines 0 comments Download
M third_party/pylint/checkers/typecheck.py View 14 chunks +72 lines, -350 lines 0 comments Download
M third_party/pylint/checkers/utils.py View 12 chunks +67 lines, -172 lines 0 comments Download
M third_party/pylint/checkers/variables.py View 18 chunks +91 lines, -481 lines 0 comments Download
M third_party/pylint/config.py View 6 chunks +27 lines, -30 lines 0 comments Download
M third_party/pylint/epylint.py View 4 chunks +48 lines, -74 lines 0 comments Download
M third_party/pylint/gui.py View 16 chunks +97 lines, -158 lines 0 comments Download
M third_party/pylint/interfaces.py View 3 chunks +40 lines, -14 lines 0 comments Download
M third_party/pylint/lint.py View 31 chunks +295 lines, -407 lines 0 comments Download
M third_party/pylint/pyreverse/diadefslib.py View 11 chunks +19 lines, -21 lines 0 comments Download
M third_party/pylint/pyreverse/diagrams.py View 11 chunks +32 lines, -32 lines 0 comments Download
M third_party/pylint/pyreverse/main.py View 5 chunks +54 lines, -48 lines 0 comments Download
M third_party/pylint/pyreverse/utils.py View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/pylint/pyreverse/writer.py View 8 chunks +33 lines, -36 lines 0 comments Download
M third_party/pylint/reporters/__init__.py View 6 chunks +13 lines, -72 lines 0 comments Download
M third_party/pylint/reporters/guireporter.py View 2 chunks +11 lines, -3 lines 0 comments Download
M third_party/pylint/reporters/html.py View 5 chunks +10 lines, -11 lines 0 comments Download
M third_party/pylint/reporters/text.py View 5 chunks +64 lines, -52 lines 0 comments Download
D third_party/pylint/testutils.py View 1 chunk +0 lines, -386 lines 0 comments Download
M third_party/pylint/utils.py View 18 chunks +159 lines, -481 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Russell (switch to Gerrit)
PTAL
6 years, 1 month ago (2014-11-15 02:12:03 UTC) #2
M-A Ruel
lgtm
6 years, 1 month ago (2014-11-15 02:12:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719313003/1
6 years, 1 month ago (2014-11-15 02:13:44 UTC) #5
vapier
lgtm
6 years, 1 month ago (2014-11-15 02:13:55 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 02:18:28 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 292955

Powered by Google App Engine
This is Rietveld 408576698