third_party/logilab/common/ureports/nodes.py - Issue 719313003: Revert "pylint: upgrade to 1.3.1"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/logilab/common/ureports/nodes.py

Issue 719313003: Revert "pylint: upgrade to 1.3.1" (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/logilab/common/ureports/nodes.py

diff --git a/third_party/logilab/common/ureports/nodes.py b/third_party/logilab/common/ureports/nodes.py

index a9585b30d2103c0b6616d7349a09e69858a14144..d63b58284cd8b3d9dae38ff58ce7bdf9c2510409 100644

--- a/third_party/logilab/common/ureports/nodes.py

+++ b/third_party/logilab/common/ureports/nodes.py

@@ -23,8 +23,6 @@ __docformat__ = "restructuredtext en"

from logilab.common.tree import VNode

-from six import string_types

class BaseComponent(VNode):

"""base report component

@@ -81,7 +79,7 @@ class Text(BaseComponent):

super(Text, self).__init__(**kwargs)

#if isinstance(data, unicode):

# data = data.encode('ascii')

- assert isinstance(data, string_types), data.__class__

+ assert isinstance(data, (str, unicode)), data.__class__

self.escaped = escaped

self.data = data