Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: third_party/logilab/common/changelog.py

Issue 719313003: Revert "pylint: upgrade to 1.3.1" (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/logilab/common/__pkginfo__.py ('k') | third_party/logilab/common/clcommands.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/logilab/common/changelog.py
diff --git a/third_party/logilab/common/changelog.py b/third_party/logilab/common/changelog.py
index 2fff2ed6505838e781151cecb76d0ae151ecc4d4..74f512416dc417ebade0069b404d1127f679831c 100644
--- a/third_party/logilab/common/changelog.py
+++ b/third_party/logilab/common/changelog.py
@@ -49,8 +49,6 @@ __docformat__ = "restructuredtext en"
import sys
from stat import S_IWRITE
-from six import string_types
-
BULLET = '*'
SUBBULLET = '-'
INDENT = ' ' * 4
@@ -66,7 +64,7 @@ class Version(tuple):
correctly printing it as X.Y.Z
"""
def __new__(cls, versionstr):
- if isinstance(versionstr, string_types):
+ if isinstance(versionstr, basestring):
versionstr = versionstr.strip(' :') # XXX (syt) duh?
parsed = cls.parse(versionstr)
else:
@@ -78,7 +76,7 @@ class Version(tuple):
versionstr = versionstr.strip(' :')
try:
return [int(i) for i in versionstr.split('.')]
- except ValueError as ex:
+ except ValueError, ex:
raise ValueError("invalid literal for version '%s' (%s)"%(versionstr, ex))
def __str__(self):
« no previous file with comments | « third_party/logilab/common/__pkginfo__.py ('k') | third_party/logilab/common/clcommands.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698