Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 719213008: SkColorTable locking serves no purpose anymore. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkColorTable locking serves no purpose anymore. The only thing the unlock methods were doing was assert their balance. This removes the unlock methods and renames the lock methods "read". BUG=skia: Committed: https://skia.googlesource.com/skia/+/775b8199a214af57c3ea7969e9d456f5f3eb137f

Patch Set 1 #

Patch Set 2 : finish up #

Patch Set 3 : simpler still #

Patch Set 4 : revert gradient shader #

Patch Set 5 : missed one #

Patch Set 6 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -176 lines) Patch
M include/core/SkBitmap.h View 1 2 2 chunks +2 lines, -56 lines 0 comments Download
M include/core/SkColorTable.h View 1 2 chunks +9 lines, -30 lines 0 comments Download
M src/core/SkBitmap.cpp View 1 2 6 chunks +13 lines, -15 lines 0 comments Download
M src/core/SkBitmapProcState_procs.h View 1 4 chunks +8 lines, -8 lines 0 comments Download
M src/core/SkColorTable.cpp View 1 4 chunks +2 lines, -18 lines 0 comments Download
M src/core/SkConfig8888.cpp View 1 3 chunks +4 lines, -8 lines 0 comments Download
M src/core/SkProcSpriteBlitter.cpp View 1 2 chunks +1 line, -4 lines 0 comments Download
M src/core/SkSpriteBlitter_RGB16.cpp View 1 4 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 3 chunks +3 lines, -5 lines 0 comments Download
M src/images/SkDecodingImageGenerator.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/images/SkImageDecoder_libjpeg.cpp View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M src/images/SkImageDecoder_libpng.cpp View 1 2 3 4 5 3 chunks +5 lines, -6 lines 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M src/images/SkImageEncoder_argb.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_arm.cpp View 1 4 chunks +2 lines, -6 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_mips_dsp.cpp View 1 4 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein
6 years ago (2014-12-02 16:42:51 UTC) #2
reed1
YAHOO lgtm
6 years ago (2014-12-02 16:54:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719213008/70001
6 years ago (2014-12-02 16:55:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/920)
6 years ago (2014-12-02 16:58:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/719213008/90001
6 years ago (2014-12-02 17:00:49 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-02 17:11:29 UTC) #10
Message was sent while issue was closed. 
Committed patchset #6 (id:90001) as
https://skia.googlesource.com/skia/+/775b8199a214af57c3ea7969e9d456f5f3eb137f

Powered by Google App Engine
This is Rietveld 408576698