src/core/SkProcSpriteBlitter.cpp - Issue 719213008: SkColorTable locking serves no purpose anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkProcSpriteBlitter.cpp

Issue 719213008: SkColorTable locking serves no purpose anymore. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: oops Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkProcSpriteBlitter.cpp

diff --git a/src/core/SkProcSpriteBlitter.cpp b/src/core/SkProcSpriteBlitter.cpp

index 2b535d947db4343d287486ca82fc45b0f95e1463..619088af6b588ce6b3fbb67294763067fcbec34c 100644

--- a/src/core/SkProcSpriteBlitter.cpp

+++ b/src/core/SkProcSpriteBlitter.cpp

@@ -26,7 +26,7 @@ public:

const SkPMColor* ctable = NULL;

if fSource.getColorTable())

- ctable = fSource.getColorTable()->lockColors();

+ ctable = fSource.getColorTable()->readColors();

while (--height >= 0)

{

@@ -34,9 +34,6 @@ public:

dst += dstRB;

src += srcRB;

}

- if fSource.getColorTable())

- fSource.getColorTable()->unlockColors();

}

private:

« no previous file with comments | « src/core/SkConfig8888.cpp ('k') | src/core/SkSpriteBlitter_RGB16.cpp » ('j') | no next file with comments »