Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 719213003: Use different icons for the overlay and non-overlay cast buttons (Closed)

Created:
6 years, 1 month ago by aberent
Modified:
6 years, 1 month ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@2214
Project:
chromium
Visibility:
Public.

Description

Use different icons for the overlay and non-overlay cast buttons We want the overlay cast icon to be visible on all backgrounds, so its background has to be at least semi-opaque. The non-overlay cast icon, however, should have the same background as the media controls, which is easiest to achive by making its background transparent. As such we need different icons for the two cases. This CL simply provides the new icons. The corresponding Blink CL, which uses them, is https://codereview.chromium.org/716613002. BUG=426373 Review URL: https://codereview.chromium.org/711083002 TBR=jam@chromium.org Cr-Commit-Position: refs/heads/master@{#303620} (cherry picked from commit bea7c9b7f0a387378fd2756430712e6042ce2c2c) Committed: https://chromium.googlesource.com/chromium/src/+/3605314e7ebea5381835cd2d3cac078496214de1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/app/resources/content_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M content/app/resources/default_100_percent/mediaplayer_cast_off.png View Binary file 0 comments Download
A + content/app/resources/default_100_percent/mediaplayer_overlay_cast_off.png View Binary file 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
aberent
6 years, 1 month ago (2014-11-13 10:54:30 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3605314e7ebea5381835cd2d3cac078496214de1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698