Use different icons for the overlay and non-overlay cast buttons

Use different icons for the overlay and non-overlay cast buttons

We want the overlay cast icon to be visible on all backgrounds, so its
background has to be at least semi-opaque. The non-overlay cast icon,
however, should have the same background as the media controls, which
is easiest to achive by making its background transparent. As such we
need different icons for the two cases.

Note that this also needs a Chromium CL for the new versions of the
icons.

BUG=426373
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185125

[aberent, 2014-11-10 18:00:07]

aberent@chromium.org changed reviewers:
+ philipj@opera.com

[aberent, 2014-11-10 18:10:47]

The corresponding Chromium CL is https://codereview.chromium.org/711083002

[philipj_slow, 2014-11-11 08:28:51]

LGTM % nit

https://codereview.chromium.org/716613002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderMediaControls.cpp (right):

https://codereview.chromium.org/716613002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderMediaControls.cpp:363: // Should never happen
ASSERT_NOT_REACHED() and remove comment.

[aberent, 2014-11-11 09:52:33]

https://codereview.chromium.org/716613002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderMediaControls.cpp (right):

https://codereview.chromium.org/716613002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderMediaControls.cpp:363: // Should never happen
On 2014/11/11 08:28:51, philipj wrote:
> ASSERT_NOT_REACHED() and remove comment.

Done.

[aberent, 2014-11-11 09:52:48]

The CQ bit was checked by aberent@chromium.org

[commit-bot: I haz the power, 2014-11-11 09:53:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/716613002/20001

[commit-bot: I haz the power, 2014-11-11 12:07:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-11 12:07:34]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/35791)

[aberent, 2014-11-11 13:33:09]

The CQ bit was checked by aberent@chromium.org

[commit-bot: I haz the power, 2014-11-11 13:34:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/716613002/20001

[commit-bot: I haz the power, 2014-11-11 13:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-11 13:34:14]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 1458.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
b7ff36ca39e662b3723ed069c9bfd43224fd176d..c800189b7156d09023b3daa9e5c633431b096dd8
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1458,7 +1458,7 @@ crbug.com/429133 [ SnowLeopard ]
virtual/textblob/fast/text/text-combine-shrink-
 
 crbug.com/384723 accessibility/chromium-only-roles.html [ Failure ]
 
-crbug.com/429843 [ Win7 Debug ] media/video-controls-with-cast-rendering.html [
Pass ImageOnlyFailure ]
+crbug.com/429843 [ Win7 Debug ] media/video-controls-with-cast-rendering.html [
NeedsRebaseline ]
 
 # crbug.com/429874: Win => Fail
 # crbug.com/431163: Debug => Crash

[aberent, 2014-11-11 13:48:07]

The CQ bit was checked by aberent@chromium.org

[commit-bot: I haz the power, 2014-11-11 13:49:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/716613002/40001

[commit-bot: I haz the power, 2014-11-11 14:59:36]

Committed patchset #3 (id:40001) as 185125