Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 711083002: Use different icons for the overlay and non-overlay cast buttons (Closed)

Created:
6 years, 1 month ago by aberent
Modified:
6 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use different icons for the overlay and non-overlay cast buttons We want the overlay cast icon to be visible on all backgrounds, so its background has to be at least semi-opaque. The non-overlay cast icon, however, should have the same background as the media controls, which is easiest to achive by making its background transparent. As such we need different icons for the two cases. This CL simply provides the new icons. The corresponding Blink CL, which uses them, is https://codereview.chromium.org/716613002. BUG=426373 Committed: https://crrev.com/bea7c9b7f0a387378fd2756430712e6042ce2c2c Cr-Commit-Position: refs/heads/master@{#303620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/app/resources/content_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M content/app/resources/default_100_percent/mediaplayer_cast_off.png View Binary file 0 comments Download
A + content/app/resources/default_100_percent/mediaplayer_overlay_cast_off.png View Binary file 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aberent
6 years, 1 month ago (2014-11-10 18:09:43 UTC) #2
jam
lgtm
6 years, 1 month ago (2014-11-11 04:27:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711083002/1
6 years, 1 month ago (2014-11-11 08:57:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 09:47:50 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 09:48:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bea7c9b7f0a387378fd2756430712e6042ce2c2c
Cr-Commit-Position: refs/heads/master@{#303620}

Powered by Google App Engine
This is Rietveld 408576698