Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 718943003: Rename updateIntrinsicContentLogicalHeight to setIntrinsicContentLogicalHeight (Closed)

Created:
6 years, 1 month ago by leviw_travelin_and_unemployed
Modified:
6 years ago
Reviewers:
cbiesinger, pdr., eae
CC:
blink-reviews, blink-reviews-rendering, cbiesinger, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rename updateIntrinsicContentLogicalHeight to setIntrinsicContentLogicalHeight Following Christian's suggestion on https://codereview.chromium.org/715083002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185178

Patch Set 1 #

Patch Set 2 : Tryin' again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -22 lines) Patch
M Source/core/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/BlockFlowPainter.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/ClipRecorder.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/ClipRecorder.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
A Source/core/paint/GraphicsContextRecorder.h View 1 1 chunk +47 lines, -0 lines 0 comments Download
A + Source/core/paint/GraphicsContextRecorder.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 2 chunks +17 lines, -10 lines 0 comments Download
A + Source/platform/graphics/GraphicsContextStateSaver.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/paint/ClipDisplayItem.h View 1 3 chunks +4 lines, -2 lines 0 comments Download
M Source/platform/graphics/paint/ClipDisplayItem.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
leviw_travelin_and_unemployed
6 years, 1 month ago (2014-11-12 04:09:15 UTC) #2
blink-reviews
Lgtm To unsubscribe from this group and stop receiving emails from it, send an email ...
6 years, 1 month ago (2014-11-12 04:28:26 UTC) #3
leviw_travelin_and_unemployed
Sadly, lgtms by email don't count :-/
6 years, 1 month ago (2014-11-12 04:36:49 UTC) #4
pdr.
On 2014/11/12 at 04:36:49, leviw wrote: > Sadly, lgtms by email don't count :-/ How ...
6 years, 1 month ago (2014-11-12 04:38:25 UTC) #5
leviw_travelin_and_unemployed
On 2014/11/12 at 04:38:25, pdr wrote: > On 2014/11/12 at 04:36:49, leviw wrote: > > ...
6 years, 1 month ago (2014-11-12 04:39:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718943003/1
6 years, 1 month ago (2014-11-12 04:39:58 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 05:07:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185178

Powered by Google App Engine
This is Rietveld 408576698