Avoid blowing away the intrinsicContentLogicalHeight when stretching height in FlexBox

Avoid blowing away the intrinsicContentLogicalHeight when stretching height in FlexBox

Cache and reset the intrinsic content logical height of children when stretching them
in FlexBox. This is to avoid them reseting it to the stretched height, which leads
us to improperly avoiding layout later when stretching is no longer necessary.

This solution is too fragile, but I couldn't come up with one that was more robust
but doesn't break the optimization.

BUG=409779
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185173

[leviw_travelin_and_unemployed, 2014-11-12 02:02:50]

leviw@chromium.org changed reviewers:
+ cbiesinger@chromium.org, eae@chromium.org, ojan@chromium.org

[eae, 2014-11-12 02:05:37]

Not the most elegant solution but seems to do the trick. LGTM/w nit. Feel free
to commit once addressed.

https://codereview.chromium.org/715083002/diff/20001/LayoutTests/fast/flexbox...
File LayoutTests/fast/flexbox/relayout-stretched-flexbox.html (right):

https://codereview.chromium.org/715083002/diff/20001/LayoutTests/fast/flexbox...
LayoutTests/fast/flexbox/relayout-stretched-flexbox.html:17: container.innerText
= "EAE likes to eat eat eat apples and bananas.";
Oh come on now, please don't lie in tests!

[leviw_travelin_and_unemployed, 2014-11-12 02:08:17]

The CQ bit was checked by leviw@chromium.org

[commit-bot: I haz the power, 2014-11-12 02:09:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/715083002/40001

[blink-reviews, 2014-11-12 02:11:30]

lgtm. Maybe rename the function to set* instead of update*? Some of our
update* functions do more than just a simple store of the given value.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-11-12 03:15:43]

Committed patchset #3 (id:40001) as 185173

[leviw_travelin_and_unemployed, 2014-11-12 03:41:14]

I'll follow-up with a rename.