Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 717933002: Clean up after getPropertyCSSValue (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
4 years, 7 months ago
Reviewers:
haraken, pdr., Yuki
CC:
blink-reviews, shans, tzik, Manuel Rego, apavlov+blink_chromium.org, Steve Block, rwlbuis, jsbell+serviceworker_chromium.org, arv+blink, blink-reviews-css, Timothy Loh, dstockwell, dglazkov+blink, blink-reviews-bindings_chromium.org, Eric Willigers, jfernandez, rjwright, nhiroki, Raymond Toy, darktears, michaeln, blink-reviews-animation_chromium.org, serviceworker-reviews, falken, Mike Lawther (Google), ed+blinkwatch_opera.com, kinuko+serviceworker, Inactive, svillar, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up after getPropertyCSSValue This patch removes the idl interfaces for getPropertyCSSValue and friends (i.e. those behind the runtime flag CSSValue), and removes code that only existed to support this. BUG=331608 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185192

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase / fix debug compile? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1026 lines) Patch
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 4 chunks +0 lines, -8 lines 0 comments Download
D Source/bindings/core/v8/custom/V8CSSValueCustom.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
M Source/bindings/core/v8/custom/custom.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayerTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/EffectInputTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 1 2 4 chunks +0 lines, -10 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/css/CSSFilterValue.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSFilterValue.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/css/CSSGridLineNamesValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSGridLineNamesValue.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/css/CSSImageSetValue.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSImageSetValue.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/css/CSSImageValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSImageValue.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 3 chunks +0 lines, -17 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 7 chunks +0 lines, -184 lines 0 comments Download
D Source/core/css/CSSPrimitiveValue.idl View 1 chunk +0 lines, -68 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSStyleDeclaration.idl View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/css/CSSTransformValue.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSTransformValue.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/css/CSSValue.h View 8 chunks +3 lines, -27 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 1 2 8 chunks +0 lines, -95 lines 0 comments Download
D Source/core/css/CSSValue.idl View 1 chunk +0 lines, -40 lines 0 comments Download
M Source/core/css/CSSValueList.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSValueList.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
D Source/core/css/CSSValueList.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/core/css/Counter.h View 2 chunks +1 line, -10 lines 0 comments Download
D Source/core/css/Counter.idl View 1 chunk +0 lines, -29 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 5 chunks +0 lines, -32 lines 0 comments Download
D Source/core/css/RGBColor.h View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/css/RGBColor.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
D Source/core/css/RGBColor.idl View 1 chunk +0 lines, -30 lines 0 comments Download
M Source/core/css/Rect.h View 6 chunks +1 line, -15 lines 0 comments Download
D Source/core/css/Rect.idl View 1 chunk +0 lines, -30 lines 0 comments Download
D Source/core/css/WebKitCSSFilterValue.idl View 1 chunk +0 lines, -48 lines 0 comments Download
D Source/core/css/WebKitCSSTransformValue.idl View 1 chunk +0 lines, -60 lines 0 comments Download
M Source/modules/presentation/Presentation.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/CacheStorage.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webaudio/PannerNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Timothy Loh
This depends on https://codereview.chromium.org/715913003/ and https://codereview.chromium.org/716963002/ landing first (these remove the remaining layout-test consumers of ...
6 years, 1 month ago (2014-11-12 01:56:18 UTC) #2
pdr.
So much deleted code! LGTM RS=me
6 years, 1 month ago (2014-11-12 02:00:52 UTC) #3
haraken
This is great! rubberstamp LGTM 2.
6 years, 1 month ago (2014-11-12 02:04:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717933002/20001
6 years, 1 month ago (2014-11-12 06:29:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/33168)
6 years, 1 month ago (2014-11-12 06:41:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717933002/40001
6 years, 1 month ago (2014-11-12 06:56:23 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 185192
6 years, 1 month ago (2014-11-12 08:24:32 UTC) #12
Stephen White
6 years, 1 month ago (2014-11-12 17:17:20 UTC) #13
Message was sent while issue was closed.
This change seems to be causing some test failures in
transitions/cross-fade-background-image.html and friends:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...

Will suppress for now, since Tim says he has a fix.

Powered by Google App Engine
This is Rietveld 408576698