Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 715913003: Remove remaining testing of getPropertyCSSValue (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, dstockwell, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove remaining testing of getPropertyCSSValue As getPropertyCSSValue, CSSPrimitiveValue, etc. are no longer web-exposed, we should stop testing them so we can delete the interface. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M LayoutTests/fast/dom/Window/get-set-properties.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/get-set-properties-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/transitions/multiple-text-shadow-transition.html View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Timothy Loh
This patch and https://codereview.chromium.org/716963002/ cover all the remaining uses of getPropertyCSSValue/etc. (unless I missed some...)
6 years, 1 month ago (2014-11-12 00:24:03 UTC) #2
pdr.
lgtm
6 years, 1 month ago (2014-11-12 01:57:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715913003/1
6 years, 1 month ago (2014-11-12 01:57:57 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 02:00:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185165

Powered by Google App Engine
This is Rietveld 408576698