content/browser/devtools/protocol/tracing_handler.h - Issue 717083003: Report trace buffer usage as number of events, not only percentage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/tracing_handler.h

Issue 717083003: Report trace buffer usage as number of events, not only percentage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_shutdown_profile_dumper.cc ('K') | « content/browser/browser_shutdown_profile_dumper.cc ('k') | content/browser/devtools/protocol/tracing_handler.cc » ('j') | content/browser/tracing/tracing_controller_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/tracing_handler.h

diff --git a/content/browser/devtools/protocol/tracing_handler.h b/content/browser/devtools/protocol/tracing_handler.h

index b20e5854a3b4555d1c621b7f2fc192817c3a5aad..29da1d6f7f7ce946e93101e5fbab799c56d2184b 100644

--- a/content/browser/devtools/protocol/tracing_handler.h

+++ b/content/browser/devtools/protocol/tracing_handler.h

@@ -49,7 +49,7 @@ class TracingHandler {

private:

void OnRecordingEnabled(scoped_refptr<DevToolsProtocol::Command> command);

- void OnBufferUsage(float usage);

+ void OnBufferUsage(float percent_full, size_t approximate_event_count);

void OnCategoriesReceived(scoped_refptr<DevToolsProtocol::Command> command,

const std::set<std::string>& category_set);