Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: Source/bindings/scripts/v8_union.py

Issue 716773002: Use union types for HTMLSelectElement.add()'s arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: don't include GlobalEventHandlers.h in UnionTypes*.cpp Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_union.py
diff --git a/Source/bindings/scripts/v8_union.py b/Source/bindings/scripts/v8_union.py
index 9d4fae6132ef654bde08bbfb2c4e7a71f452d2fb..7c45aca871abed0b32631f7921b99e4ca706a881 100644
--- a/Source/bindings/scripts/v8_union.py
+++ b/Source/bindings/scripts/v8_union.py
@@ -11,6 +11,15 @@ UNION_H_INCLUDES = frozenset([
'platform/heap/Handle.h',
])
+UNION_CPP_INCLUDES_BLACKLIST = frozenset([
+ # This header defines static functions needed to implement event handler
+ # attributes in interfaces that implement GlobalEventHandlers. They are not
+ # needed or used by UnionTypes*.cpp, so including the header causes
+ # compilation errors.
haraken 2014/11/12 08:34:34 Add a FIXME?
Jens Widell 2014/11/12 08:40:13 Done.
+ 'core/dom/GlobalEventHandlers.h',
+])
+
+
cpp_includes = set()
header_forward_decls = set()
@@ -38,7 +47,7 @@ def union_context(union_types, interfaces_info):
return {
'containers': [container_context(union_type, interfaces_info)
for union_type in union_types_for_containers],
- 'cpp_includes': sorted(cpp_includes),
+ 'cpp_includes': sorted(cpp_includes - UNION_CPP_INCLUDES_BLACKLIST),
'header_forward_decls': sorted(header_forward_decls),
'header_includes': sorted(UNION_H_INCLUDES),
'nullable_cpp_types': nullable_cpp_types,
« no previous file with comments | « Source/bindings/core/v8/custom/V8HTMLOptionsCollectionCustom.cpp ('k') | Source/core/html/HTMLOptionsCollection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698