Use union types for HTMLSelectElement.add()'s arguments

Source/bindings/scripts/v8_union.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import v8_utilities
 
 
 UNION_H_INCLUDES = frozenset([
     'bindings/core/v8/ExceptionState.h',
     'bindings/core/v8/V8Binding.h',
     'platform/heap/Handle.h',
 ])
 
+UNION_CPP_INCLUDES_BLACKLIST = frozenset([
+    # This header defines static functions needed to implement event handler
+    # attributes in interfaces that implement GlobalEventHandlers. They are not
+    # needed or used by UnionTypes*.cpp, so including the header causes
+    # compilation errors.

[haraken, 2014/11/12 08:34:34]

Add a FIXME?

[Jens Widell, 2014/11/12 08:40:13]

Done.

+    'core/dom/GlobalEventHandlers.h',
+])
+
+
 cpp_includes = set()
 header_forward_decls = set()
 
 
 def union_context(union_types, interfaces_info):
     # For container classes we strip nullable wrappers. For example,
     # both (A or B)? and (A? or B) will become AOrB. This should be OK
     # because container classes can handle null and it seems that
     # distinguishing (A or B)? and (A? or B) doesn't make sense.
     container_cpp_types = set()
     union_types_for_containers = set()
     nullable_cpp_types = set()
     for union_type in union_types:
         cpp_type = union_type.cpp_type
         if cpp_type not in container_cpp_types:
             union_types_for_containers.add(union_type)
             container_cpp_types.add(cpp_type)
         if union_type.includes_nullable_type:
             nullable_cpp_types.add(cpp_type)
 
     union_types_for_containers = sorted(union_types_for_containers,
                                         key=lambda union_type: union_type.cpp_type)
     nullable_cpp_types = sorted(nullable_cpp_types)
 
     return {
         'containers': [container_context(union_type, interfaces_info)
                        for union_type in union_types_for_containers],
-        'cpp_includes': sorted(cpp_includes),
+        'cpp_includes': sorted(cpp_includes - UNION_CPP_INCLUDES_BLACKLIST),
         'header_forward_decls': sorted(header_forward_decls),
         'header_includes': sorted(UNION_H_INCLUDES),
         'nullable_cpp_types': nullable_cpp_types,
     }
 
 
 def container_context(union_type, interfaces_info):
     members = []
 
     # These variables refer to member contexts if the given union type has
@@ skipping 68 matching lines @@
         'cpp_value_to_v8_value': member.cpp_value_to_v8_value(
             cpp_value='impl.getAs%s()' % member.name, isolate='isolate',
             creation_context='creationContext'),
         'is_traceable': member.is_traceable,
         'rvalue_cpp_type': member.cpp_type_args(used_as_rvalue_type=True),
         'specific_type_enum': 'SpecificType' + member.name,
         'type_name': member.name,
         'v8_value_to_local_cpp_value': member.v8_value_to_local_cpp_value(
             {}, 'v8Value', 'cppValue', needs_exception_state_for_string=True),
     }