Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: Source/core/html/HTMLOptionsCollection.h

Issue 716773002: Use union types for HTMLSelectElement.add()'s arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: don't include GlobalEventHandlers.h in UnionTypes*.cpp Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLOptionsCollection.h
diff --git a/Source/core/html/HTMLOptionsCollection.h b/Source/core/html/HTMLOptionsCollection.h
index 86a2c8c9e2841d8ec306a5f83907f4102738b5f1..a112371f0ecdde8d86c7a194589e65f55c0ac5d5 100644
--- a/Source/core/html/HTMLOptionsCollection.h
+++ b/Source/core/html/HTMLOptionsCollection.h
@@ -30,6 +30,8 @@
namespace blink {
class ExceptionState;
+class HTMLOptionElementOrHTMLOptGroupElement;
+class HTMLElementOrLong;
class NodeListOrElement;
class HTMLOptionsCollection final : public HTMLCollection {
@@ -39,8 +41,7 @@ public:
HTMLOptionElement* item(unsigned offset) const { return toHTMLOptionElement(HTMLCollection::item(offset)); }
- void add(PassRefPtrWillBeRawPtr<HTMLOptionElement>, ExceptionState&);
- void add(PassRefPtrWillBeRawPtr<HTMLOptionElement>, int index, ExceptionState&);
+ void add(const HTMLOptionElementOrHTMLOptGroupElement&, const HTMLElementOrLong&, ExceptionState&);
void remove(int index);
int selectedIndex() const;

Powered by Google App Engine
This is Rietveld 408576698