Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 716733002: Merge 184652 "Disallow non-flexbox child renderers for RenderMedia" (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
philipj_slow
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, blink-reviews-rendering, jchaffraix+rendering, rune+blink
Project:
blink
Visibility:
Public.

Description

Merge 184652 "Disallow non-flexbox child renderers for RenderMedia" > Disallow non-flexbox child renderers for RenderMedia > > Inline children of replaced content is not handled and triggered the > ASSERT(curr->isRenderInline()) UNKNOWN in RenderInline::splitInlines(). > > The render tree at the point of failure was: > > RenderView 0xd0c23404010 #document 0x2be215c04b48 > RenderBlock 0xd0c2341c010 HTML 0x2be215c101a8 > RenderBody 0xd0c2341c110 BODY 0x2be215c102b8 > RenderBlock (anonymous) 0xd0c2341c310 > RenderVideo 0xd0c23420010 VIDEO 0x2be215c48010 > * RenderInline (relative positioned) 0xd0c23424010 DIV 0x2be215c68010 > RenderBlock (anonymous) 0xd0c2341c210 > RenderBlock (anonymous) 0xd0c2341c410 > > Making ::-webkit-media-controls* internal would have fixed this: > https://codereview.chromium.org/662243003/ > https://groups.google.com/a/chromium.org/d/msg/blink-dev/YCIaYPa_DhI/RyDlcHmD1_wJ > > Unfortunately, that is not without risk. This fix allows > ::-webkit-media-controls { display: none; } to keep working until the > usage can be measured. > > BUG=415407, 426759 > > Review URL: https://codereview.chromium.org/689613002 TBR=philipj@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, --4 lines) Patch
A + LayoutTests/media/webkit-media-controls-display.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/media/webkit-media-controls-display-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/media/webkit-media-controls-webkit-appearance.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/media/webkit-media-controls-webkit-appearance-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/RenderMedia.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderMedia.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
philipj_slow
6 years, 1 month ago (2014-11-11 08:35:11 UTC) #1
philipj_slow
6 years, 1 month ago (2014-11-11 08:36:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r185110.

Powered by Google App Engine
This is Rietveld 408576698