Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 662243003: Use ::-internal-media-controls* instead of ::-webkit-media-controls* (Closed)

Created:
6 years, 2 months ago by philipj_slow
Modified:
6 years, 1 month ago
CC:
blink-reviews, nessy, blink-reviews-css, gasubic, ed+blinkwatch_opera.com, eric.carlson_apple.com, fs, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, apavlov+blink_chromium.org, darktears, rwlbuis, vcarbune.chromium, rune+blink
Project:
blink
Visibility:
Public.

Description

Use ::-internal-media-controls* instead of ::-webkit-media-controls* BUG=415407

Patch Set 1 #

Patch Set 2 : discard -internal-* by string matching #

Patch Set 3 : introduce PseudoInternalCustomElement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -89 lines) Patch
M LayoutTests/fullscreen/video-controls-drag.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fullscreen/video-controls-override.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fullscreen/video-controls-override-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fullscreen/video-controls-timeline.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/controls-css-overload.html View 1 chunk +14 lines, -25 lines 0 comments Download
A LayoutTests/media/controls-css-overload-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
D LayoutTests/media/controls-css-overload-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/media/media-controls.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelector.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 2 4 chunks +4 lines, -2 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/mediaControls.css View 14 chunks +23 lines, -23 lines 0 comments Download
M Source/core/css/mediaControlsAndroid.css View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSGrammar.y View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 12 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (2 generated)
philipj_slow
jchaffraix, can you PTAL? I want to do the same thing for pseudo element names ...
6 years, 2 months ago (2014-10-22 14:40:24 UTC) #2
rune
On 2014/10/22 at 14:40:24, philipj wrote: > Any feedback would be appreciated. I can take ...
6 years, 2 months ago (2014-10-22 14:49:10 UTC) #3
rune
On 2014/10/22 at 14:40:24, philipj wrote: > jchaffraix, can you PTAL? > > I want ...
6 years, 2 months ago (2014-10-22 17:58:18 UTC) #4
Julien - ping for review
On 2014/10/22 at 17:58:18, rune wrote: > On 2014/10/22 at 14:40:24, philipj wrote: > > ...
6 years, 2 months ago (2014-10-22 22:26:02 UTC) #5
philipj_slow
discard -internal-* by string matching
6 years, 2 months ago (2014-10-23 11:43:27 UTC) #6
philipj_slow
introduce PseudoInternalCustomElement
6 years, 2 months ago (2014-10-23 12:39:09 UTC) #7
philipj_slow
What I have now seems to work, but there is an issue. First, rune discovered ...
6 years, 2 months ago (2014-10-23 13:08:05 UTC) #8
Julien - ping for review
On 2014/10/23 at 13:08:05, philipj wrote: > What I have now seems to work, but ...
6 years, 2 months ago (2014-10-23 14:57:11 UTC) #9
philipj_slow
On 2014/10/23 14:57:11, Julien Chaffraix - PST wrote: > On 2014/10/23 at 13:08:05, philipj wrote: ...
6 years, 2 months ago (2014-10-23 15:08:26 UTC) #10
Julien - ping for review
On 2014/10/23 at 15:08:26, philipj wrote: > On 2014/10/23 14:57:11, Julien Chaffraix - PST wrote: ...
6 years, 2 months ago (2014-10-23 18:07:36 UTC) #11
Julien - ping for review
On 2014/10/23 at 18:07:36, Julien Chaffraix - PST wrote: > On 2014/10/23 at 15:08:26, philipj ...
6 years, 2 months ago (2014-10-23 18:09:41 UTC) #12
philipj_slow
I'd love to unexpose these, but what the CL descrption doesn't say is that the ...
6 years, 2 months ago (2014-10-23 18:29:13 UTC) #13
rune
On 2014/10/23 at 18:29:13, philipj wrote: > I'd love to unexpose these, but what the ...
6 years, 2 months ago (2014-10-23 22:31:12 UTC) #14
philipj_slow
On 2014/10/23 22:31:12, rune wrote: > On 2014/10/23 at 18:29:13, philipj wrote: > > I'd ...
6 years, 2 months ago (2014-10-24 08:23:07 UTC) #15
philipj_slow
Philip, I need your input as an API OWNER. Comment #8 describes a problem with ...
6 years, 2 months ago (2014-10-24 08:34:22 UTC) #17
Mike West
On 2014/10/24 08:34:22, philipj wrote: > Philip, I need your input as an API OWNER. ...
6 years, 2 months ago (2014-10-24 10:44:48 UTC) #18
philipj_slow
6 years, 1 month ago (2014-10-29 10:15:26 UTC) #19
blink-dev said no, closing this in favor of
https://codereview.chromium.org/689613002/

Powered by Google App Engine
This is Rietveld 408576698