Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: Source/core/rendering/RenderMedia.h

Issue 716733002: Merge 184652 "Disallow non-flexbox child renderers for RenderMedia" (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/2171/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 private: 56 private:
57 virtual RenderObjectChildList* virtualChildren() OVERRIDE FINAL { return chi ldren(); } 57 virtual RenderObjectChildList* virtualChildren() OVERRIDE FINAL { return chi ldren(); }
58 virtual const RenderObjectChildList* virtualChildren() const OVERRIDE FINAL { return children(); } 58 virtual const RenderObjectChildList* virtualChildren() const OVERRIDE FINAL { return children(); }
59 59
60 virtual LayerType layerTypeRequired() const OVERRIDE { return NormalLayer; } 60 virtual LayerType layerTypeRequired() const OVERRIDE { return NormalLayer; }
61 61
62 // FIXME: RenderMedia::layout makes assumptions about what children are allo wed 62 // FIXME: RenderMedia::layout makes assumptions about what children are allo wed
63 // so we can't support generated content. 63 // so we can't support generated content.
64 virtual bool canHaveGeneratedChildren() const OVERRIDE FINAL { return false; } 64 virtual bool canHaveGeneratedChildren() const OVERRIDE FINAL { return false; }
65 virtual bool canHaveChildren() const OVERRIDE FINAL { return true; } 65 virtual bool canHaveChildren() const OVERRIDE FINAL { return true; }
66 virtual bool isChildAllowed(RenderObject*, RenderStyle*) const override fina l;
66 67
67 virtual const char* renderName() const OVERRIDE { return "RenderMedia"; } 68 virtual const char* renderName() const OVERRIDE { return "RenderMedia"; }
68 virtual bool isMedia() const OVERRIDE FINAL { return true; } 69 virtual bool isMedia() const OVERRIDE FINAL { return true; }
69 virtual bool isImage() const OVERRIDE FINAL { return false; } 70 virtual bool isImage() const OVERRIDE FINAL { return false; }
70 virtual void paintReplaced(PaintInfo&, const LayoutPoint&) OVERRIDE; 71 virtual void paintReplaced(PaintInfo&, const LayoutPoint&) OVERRIDE;
71 72
72 RenderObjectChildList m_children; 73 RenderObjectChildList m_children;
73 }; 74 };
74 75
75 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderMedia, isMedia()); 76 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderMedia, isMedia());
76 77
77 } // namespace blink 78 } // namespace blink
78 79
79 #endif // RenderMedia_h 80 #endif // RenderMedia_h
OLDNEW
« no previous file with comments | « LayoutTests/media/webkit-media-controls-webkit-appearance-expected.html ('k') | Source/core/rendering/RenderMedia.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698